Skip to content

Remove unused EIS types #5107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2025
Merged

Remove unused EIS types #5107

merged 1 commit into from
Aug 12, 2025

Conversation

pquentin
Copy link
Member

@pquentin pquentin commented Aug 11, 2025

The API that was using them was removed in #4212.

This was caught by #5106.

They were removed in PR 4212.
Copy link
Contributor

Following you can find the validation changes against the target branch for the APIs.

No changes detected.

You can validate these APIs yourself by using the make validate target.

@pquentin pquentin merged commit dcfb0ff into main Aug 12, 2025
15 of 16 checks passed
@pquentin pquentin deleted the remove-eis-types branch August 12, 2025 07:26
Copy link
Contributor

The backport to 8.19 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.19 8.19
# Navigate to the new working tree
cd .worktrees/backport-8.19
# Create a new branch
git switch --create backport-5107-to-8.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 dcfb0ffe0fd80dbc0aa57ef5ad63ebbef438a203
# Push it to GitHub
git push --set-upstream origin backport-5107-to-8.19
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.19

Then, create a pull request where the base branch is 8.19 and the compare/head branch is backport-5107-to-8.19.

Copy link
Contributor

The backport to 8.18 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.18 8.18
# Navigate to the new working tree
cd .worktrees/backport-8.18
# Create a new branch
git switch --create backport-5107-to-8.18
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 dcfb0ffe0fd80dbc0aa57ef5ad63ebbef438a203
# Push it to GitHub
git push --set-upstream origin backport-5107-to-8.18
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.18

Then, create a pull request where the base branch is 8.18 and the compare/head branch is backport-5107-to-8.18.

Copy link
Contributor

The backport to 9.0 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.0 9.0
# Navigate to the new working tree
cd .worktrees/backport-9.0
# Create a new branch
git switch --create backport-5107-to-9.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 dcfb0ffe0fd80dbc0aa57ef5ad63ebbef438a203
# Push it to GitHub
git push --set-upstream origin backport-5107-to-9.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.0

Then, create a pull request where the base branch is 9.0 and the compare/head branch is backport-5107-to-9.0.

Copy link
Contributor

The backport to 9.1 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.1 9.1
# Navigate to the new working tree
cd .worktrees/backport-9.1
# Create a new branch
git switch --create backport-5107-to-9.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 dcfb0ffe0fd80dbc0aa57ef5ad63ebbef438a203
# Push it to GitHub
git push --set-upstream origin backport-5107-to-9.1
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.1

Then, create a pull request where the base branch is 9.1 and the compare/head branch is backport-5107-to-9.1.

pquentin added a commit that referenced this pull request Aug 12, 2025
They were removed in PR 4212.

(cherry picked from commit dcfb0ff)

# Conflicts:
#	output/schema/schema.json
pquentin added a commit that referenced this pull request Aug 12, 2025
They were removed in PR 4212.

(cherry picked from commit dcfb0ff)

# Conflicts:
#	output/schema/schema.json
#	specification/inference/_types/CommonTypes.ts
pquentin added a commit that referenced this pull request Aug 12, 2025
They were removed in PR 4212.

(cherry picked from commit dcfb0ff)

# Conflicts:
#	output/schema/schema.json
pquentin added a commit that referenced this pull request Aug 12, 2025
They were removed in PR 4212.

(cherry picked from commit dcfb0ff)

# Conflicts:
#	output/schema/schema.json
#	specification/inference/_types/CommonTypes.ts
@pquentin
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
9.1
9.0
8.19
8.18

Questions ?

Please refer to the Backport tool documentation

pquentin added a commit that referenced this pull request Aug 12, 2025
* Remove unused EIS types (#5107)

They were removed in PR 4212.

(cherry picked from commit dcfb0ff)

# Conflicts:
#	output/schema/schema.json
#	specification/inference/_types/CommonTypes.ts

* Fix merge
pquentin added a commit that referenced this pull request Aug 12, 2025
They were removed in PR 4212.

(cherry picked from commit dcfb0ff)

# Conflicts:
#	output/schema/schema.json
pquentin added a commit that referenced this pull request Aug 12, 2025
* Remove unused EIS types (#5107)

They were removed in PR 4212.

(cherry picked from commit dcfb0ff)

# Conflicts:
#	output/schema/schema.json
#	specification/inference/_types/CommonTypes.ts

* Fix merge
pquentin added a commit that referenced this pull request Aug 12, 2025
They were removed in PR 4212.

(cherry picked from commit dcfb0ff)

# Conflicts:
#	output/schema/schema.json
szybia added a commit that referenced this pull request Aug 12, 2025
* origin/main:
  [DOCS] Fix typos in the shared overlays file (#5124)
  Update specification output
  Remove unused EIS types (#5107)
  No native utility types validation lint (#4567)
  Document reindexing failures (#5031)
  Add dangling types to validation-errors.json (#5106)
  Update specification output
  Change `KeyedPercentiles` value type from `long` to `double` (#5108)
  [DOCS]: Add descriptions to API tags (#5098)
  Bump form-data and @redocly/cli in /docs/examples (#5074)
  Update specification output
  Adds cat-h values (#5096)
  Bump @eslint/plugin-kit from 0.3.3 to 0.3.4 in /specification (#5053)
  Update specification output
  [DOCS] Adds Ruby bulk helper to BulkRequest documentation (#5057)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants