Conversation
Contributor
Author
This was referenced Sep 10, 2023
senekor
force-pushed
the
unimpl-todo
branch
from
7949362 to
dde865a
Compare
This was referenced Sep 11, 2023
Merged
senekor
force-pushed
the
unimpl-todo
branch
from
dde865a to
2210a2d
Compare
senekor
force-pushed
the
unimpl-todo
branch
3 times, most recently
from
654a972 to
d94f686
Compare
This was referenced Sep 12, 2023
The difference is one of intent, and the actual panic message. See the docs why todo is more appropriate: https://doc.rust-lang.org/stable/std/macro.todo.html [no important files changed] closes #1598
senekor
force-pushed
the
unimpl-todo
branch
from
d94f686 to
6d4fa9f
Compare
This was referenced Sep 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The difference is one of intent, and the actual panic message.
See the docs why todo is more appropriate:
https://doc.rust-lang.org/stable/std/macro.todo.html
[no important files changed]
closes #1598