Skip to content

Sync variable-length-quantity with problem-specifications#1731

Merged
senekor merged 1 commit intomainfrom
variable-length-quantity-sync-prob-spec
Sep 18, 2023
Merged

Sync variable-length-quantity with problem-specifications#1731
senekor merged 1 commit intomainfrom
variable-length-quantity-sync-prob-spec

Conversation

@senekor
Copy link
Contributor

@senekor senekor commented Sep 12, 2023

Notably, this removes any tests about overflow as well as the
overflow variant from the error enum in the stub.
Overflow handling is a valuable thing to learn and practice,
but there are other exercises which do that.
So it seems unnecesary to expand the case only on the Rust track
and maintain our own additional tests.

This is a backwards compatible change,
submissions which choose to handle overflow should still work fine.

@senekor senekor force-pushed the variable-length-quantity-sync-prob-spec branch from 00ce736 to 7732198 Compare September 12, 2023 19:14
@senekor senekor marked this pull request as draft September 13, 2023 05:02
@senekor
Copy link
Contributor Author

senekor commented Sep 13, 2023

It looks like the test suite here was significantly out of sync with problem-specifications. I should go through the existing tests and see which of them are worth preserving / upstreaming.

@senekor senekor changed the base branch from no-test-prefix to to_hex-fn-for-templates September 13, 2023 06:26
@senekor senekor force-pushed the variable-length-quantity-sync-prob-spec branch from 7732198 to 4835382 Compare September 13, 2023 06:26
@senekor senekor force-pushed the to_hex-fn-for-templates branch from c95f2fc to 268aa3d Compare September 13, 2023 16:56
@senekor senekor force-pushed the variable-length-quantity-sync-prob-spec branch from 4835382 to 516a780 Compare September 13, 2023 16:56
@senekor senekor force-pushed the to_hex-fn-for-templates branch from 268aa3d to ec74492 Compare September 13, 2023 20:42
@senekor senekor force-pushed the variable-length-quantity-sync-prob-spec branch from 516a780 to d747e54 Compare September 13, 2023 20:42
@senekor senekor force-pushed the to_hex-fn-for-templates branch from ec74492 to 9cdaed0 Compare September 13, 2023 20:43
@senekor senekor force-pushed the variable-length-quantity-sync-prob-spec branch from d747e54 to 5afb539 Compare September 13, 2023 20:43
@senekor senekor force-pushed the to_hex-fn-for-templates branch from 9cdaed0 to 4a18b45 Compare September 13, 2023 20:44
@senekor senekor force-pushed the variable-length-quantity-sync-prob-spec branch from 5afb539 to 8d11e88 Compare September 13, 2023 20:44
@senekor senekor force-pushed the to_hex-fn-for-templates branch from 4a18b45 to f87739c Compare September 13, 2023 20:46
@senekor senekor force-pushed the variable-length-quantity-sync-prob-spec branch from 8d11e88 to c0cd7ec Compare September 13, 2023 20:46
@senekor senekor force-pushed the to_hex-fn-for-templates branch from f87739c to 2793278 Compare September 14, 2023 14:51
@senekor senekor force-pushed the variable-length-quantity-sync-prob-spec branch from c0cd7ec to 8c0ef6f Compare September 14, 2023 14:51
@senekor senekor force-pushed the to_hex-fn-for-templates branch from 2793278 to 837fa81 Compare September 14, 2023 15:16
@senekor senekor force-pushed the variable-length-quantity-sync-prob-spec branch from 8c0ef6f to 999be4c Compare September 14, 2023 15:16
Base automatically changed from to_hex-fn-for-templates to main September 14, 2023 18:29
@senekor senekor force-pushed the variable-length-quantity-sync-prob-spec branch from 999be4c to 8795a15 Compare September 16, 2023 15:47
@senekor senekor changed the base branch from main to symlink-prob-spec September 16, 2023 20:41
@senekor senekor force-pushed the variable-length-quantity-sync-prob-spec branch from 8795a15 to cc8f526 Compare September 16, 2023 20:41
@senekor senekor force-pushed the variable-length-quantity-sync-prob-spec branch from cc8f526 to 1376faa Compare September 17, 2023 18:25
@senekor senekor changed the title Sync variable-length-quantity with problem spec Sync variable-length-quantity with problem-specifications Sep 17, 2023
@senekor
Copy link
Contributor Author

senekor commented Sep 17, 2023

Apart from the overflow thing, I did not investigate much further what the overlap of the two test suites is. They are very different, trying to figure out a submission that passes one test suite but not the other would've been difficult.

@senekor senekor marked this pull request as ready for review September 17, 2023 18:28
Base automatically changed from symlink-prob-spec to main September 18, 2023 10:24
Notably, this removes any tests about overflow as well as the
overflow variant from the error enum in the stub.
Overflow handling is a valuable thing to learn and practice,
but there are other exercises which do that.
So it seems unnecesary to expand the case only on the Rust track
and maintain our own additional tests.

This is a backwards compatible change,
submissions which choose to handle overflow should still work fine.
@senekor senekor force-pushed the variable-length-quantity-sync-prob-spec branch from 1376faa to f6ceeda Compare September 18, 2023 15:13
@senekor senekor merged commit 1030698 into main Sep 18, 2023
@senekor senekor deleted the variable-length-quantity-sync-prob-spec branch September 18, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants