Sync variable-length-quantity with problem-specifications#1731
Merged
Conversation
This was referenced Sep 12, 2023
Merged
Contributor
Author
00ce736 to
7732198
Compare
Contributor
Author
|
It looks like the test suite here was significantly out of sync with problem-specifications. I should go through the existing tests and see which of them are worth preserving / upstreaming. |
7732198 to
4835382
Compare
c95f2fc to
268aa3d
Compare
4835382 to
516a780
Compare
268aa3d to
ec74492
Compare
516a780 to
d747e54
Compare
ec74492 to
9cdaed0
Compare
d747e54 to
5afb539
Compare
9cdaed0 to
4a18b45
Compare
5afb539 to
8d11e88
Compare
4a18b45 to
f87739c
Compare
8d11e88 to
c0cd7ec
Compare
f87739c to
2793278
Compare
c0cd7ec to
8c0ef6f
Compare
2793278 to
837fa81
Compare
8c0ef6f to
999be4c
Compare
999be4c to
8795a15
Compare
8795a15 to
cc8f526
Compare
This was referenced Sep 16, 2023
cc8f526 to
1376faa
Compare
Contributor
Author
|
Apart from the overflow thing, I did not investigate much further what the overlap of the two test suites is. They are very different, trying to figure out a submission that passes one test suite but not the other would've been difficult. |
Notably, this removes any tests about overflow as well as the overflow variant from the error enum in the stub. Overflow handling is a valuable thing to learn and practice, but there are other exercises which do that. So it seems unnecesary to expand the case only on the Rust track and maintain our own additional tests. This is a backwards compatible change, submissions which choose to handle overflow should still work fine.
1376faa to
f6ceeda
Compare
ErikSchierboom
approved these changes
Sep 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Notably, this removes any tests about overflow as well as the
overflow variant from the error enum in the stub.
Overflow handling is a valuable thing to learn and practice,
but there are other exercises which do that.
So it seems unnecesary to expand the case only on the Rust track
and maintain our own additional tests.
This is a backwards compatible change,
submissions which choose to handle overflow should still work fine.