Conversation
Contributor
Author
This was referenced Sep 11, 2023
7949362 to
dde865a
Compare
a4d3b6b to
883e45d
Compare
This was referenced Sep 11, 2023
Merged
dde865a to
2210a2d
Compare
883e45d to
c4a2c76
Compare
2210a2d to
bd1e01c
Compare
c4a2c76 to
321824b
Compare
bd1e01c to
654a972
Compare
321824b to
08ee069
Compare
654a972 to
d94f686
Compare
08ee069 to
655c176
Compare
This was referenced Sep 12, 2023
d94f686 to
6d4fa9f
Compare
655c176 to
4696194
Compare
4696194 to
8f44f00
Compare
ErikSchierboom
approved these changes
Sep 14, 2023
Member
ErikSchierboom
left a comment
There was a problem hiding this comment.
Thanks for adding [no important files changed] to the commit body.
Member
Contributor
Author
|
Oh noooo 😨 how did I screw that up 😭 |
Contributor
Author
|
It looks like I had the line in the PR description, but not in the commit message body. I presume when there is only one commit, this repo is setup to pick the body of the single commit, not the PR description. I'm used to the latter, but should've double checked... |
Member
|
Well, lesson learned I guess! It's easy to make this mistake. |
I proposed to make |
This was referenced Sep 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

[no important files changed]
closes #1720