Skip to content

Python Viewer Navmesh Visualization via Key Press Toggle#1555

Merged
JuanTheEngineer merged 33 commits intomainfrom
python-viewer
Nov 8, 2021
Merged

Python Viewer Navmesh Visualization via Key Press Toggle#1555
JuanTheEngineer merged 33 commits intomainfrom
python-viewer

Conversation

@JuanTheEngineer
Copy link
Copy Markdown
Contributor

@JuanTheEngineer JuanTheEngineer commented Nov 1, 2021

Motivation and Context

This PR migrates the Navmesh Recompute and Toggle feature to the python viewer.

How Has This Been Tested

Building and running viewer.py

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Nov 1, 2021
JuanTheEngineer and others added 14 commits November 2, 2021 11:16
* Add MOTION mouse mode

* Create and Remove functions for selector icon

* Rotate and Translate feature in motion mode
* Refactor conda OSX into command

* Further parameterize the OSX conda build

* Update .circleci/config.yml

Co-authored-by: Oleksandr <maksymets.o@gmail.com>

* Fix missing conditional

* Add missing params

* Try to update and test CI upload

* Fix code change

* Further adjust matrix args

* Finalize nightly builds

* Add release tag config

Co-authored-by: Oleksandr <maksymets.o@gmail.com>
@JuanTheEngineer JuanTheEngineer marked this pull request as ready for review November 4, 2021 14:56
Copy link
Copy Markdown
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small fixes and ready to go.

Comment thread examples/viewer.py Outdated
Comment thread examples/viewer.py Outdated
@JuanTheEngineer JuanTheEngineer merged commit befcc53 into main Nov 8, 2021
@JuanTheEngineer JuanTheEngineer deleted the python-viewer branch November 8, 2021 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants