Skip to content

Fairmotion Shortest Path Generation with Key Press#1560

Merged
JuanTheEngineer merged 38 commits intomainfrom
fairmotion-shortest-path
Nov 8, 2021
Merged

Fairmotion Shortest Path Generation with Key Press#1560
JuanTheEngineer merged 38 commits intomainfrom
fairmotion-shortest-path

Conversation

@JuanTheEngineer
Copy link
Copy Markdown
Contributor

@JuanTheEngineer JuanTheEngineer commented Nov 4, 2021

Motivation and Context

This Draft PR aims to add the shortest path calculation and visualization.

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

JuanTheEngineer and others added 23 commits October 31, 2021 17:13
@JuanTheEngineer
Adding the MOTION mouse mode
4210b2d
@JuanTheEngineer
First Attempt to 'Select" character, still broken
4315fe7
@JuanTheEngineer
Add create and remove functions for selector icon
d980785
@JuanTheEngineer
Writing the MOTION selection logic
4fc4d67
@JuanTheEngineer
Add rotate and translate feature in motion mode
730d03d
@JuanTheEngineer
Update magnum bindings
45309cf
@JuanTheEngineer
Refactor and Bug fixes
a80ac45
@JuanTheEngineer
Initial commit to build navmesh generating
d58c4ad
@JuanTheEngineer
Resolving Review Changes
dc3be6a
@JuanTheEngineer
Add command-line args to accept filename, model data, and motion data
07330b0
@JuanTheEngineer
First draft of Save/Fetch methods and saving logic
69a5364
@JuanTheEngineer
Add Save file Key Press 'P' with several functionalities
b15584c
@JuanTheEngineer
Add Load/Fetch data from file Key Press 'L'
8adc7fa
@JuanTheEngineer
Debugging reconfigure
677f9f0
@JuanTheEngineer
Remove name key from data, and save and fetch including position data
a6f70ad
@JuanTheEngineer
Final Draft of Save\Load Functions
607c10a
@JuanTheEngineer
Fixing bug in python-viewer with draw event callable argument (#1558)
77bc7af
@jturner65 @JuanTheEngineer
[BugFix]--bypass test_sensor tests if no torch is found. (#1559)
8a2c654 
* --bypass test if no torch is found.
@JuanTheEngineer
Fairmotion Character Positioning via MOTION MouseMode (#1552)
c772968 
* Add MOTION mouse mode

* Create and Remove functions for selector icon

* Rotate and Translate feature in motion mode
@Skylion007 @mathfac @JuanTheEngineer
Build OSX Conda Nightly (#1430)
b2b3039 
* Refactor conda OSX into command

* Further parameterize the OSX conda build

* Update .circleci/config.yml

Co-authored-by: Oleksandr <maksymets.o@gmail.com>

* Fix missing conditional

* Add missing params

* Try to update and test CI upload

* Fix code change

* Further adjust matrix args

* Finalize nightly builds

* Add release tag config

Co-authored-by: Oleksandr <maksymets.o@gmail.com>
@JuanTheEngineer
Navmesh Recompute and Toggle
9ea6fc4
@JuanTheEngineer
Key press 'J' to generate and display shortest path
d2f3ed8
@JuanTheEngineer
Making recompute NavMesh occur on application start
003baa8
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Nov 4, 2021
aclegg3
aclegg3 approved these changes Nov 8, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flesh out the description a bit to note why you are adding this and summarize what it does. Fix the small details I noted and ready to go.

Comment thread examples/motion_viewer.py Outdated
Comment thread examples/motion_viewer.py Outdated
Comment thread examples/viewer.py Outdated
JuanTheEngineer and others added 2 commits November 8, 2021 13:12
@JuanTheEngineer @aclegg3
Update examples/motion_viewer.py
3670157 
Co-authored-by: Alexander Clegg <alexanderwclegg@gmail.com>
@JuanTheEngineer
Revising minor changes
815c1f0
@JuanTheEngineer JuanTheEngineer marked this pull request as ready for review November 8, 2021 21:26
@JuanTheEngineer JuanTheEngineer merged commit 5ade956 into main Nov 8, 2021
@jturner65 jturner65 deleted the fairmotion-shortest-path branch November 29, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aclegg3 aclegg3 aclegg3 approved these changes

Assignees

No one assigned

Labels

CLA Signed Do not delete this pull request or issue due to inactivity.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@JuanTheEngineer @aclegg3 @facebook-github-bot @jturner65 @Skylion007