UX improvement to banner warnings and errors #3537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliette
reviewed
Dec 14, 2021
elliette
approved these changes
Dec 14, 2021
|
Thanks for turning this into a PR. At the moment, there is a bit of a gap between what we tell users what they can do in debug mode and what they would find easy to do. In addition to UI improvements we might make to the perf page, I'm hoping to turn each task mentioned in the warning message (e.g., "building widgets") into a link to a how-to guide. |
We may be able to do this fairly soon. I know @johnpryan has been looking into writing some documentation for these features. |
|
We will hold off on landing this PR until we have more actionable information we can point users to (flutter.dev documentation, debugging guides, etc.). |
|
Is there an issue # for creating those docs? |
|
@InMatrix are you opposed to landing this? |
|
I have no problem with merging this change. |
CoderDake
added a commit
to CoderDake/devtools
that referenced
this pull request
Oct 10, 2022
rename release_note_helper First step towards an official verify :D add verify command add ability to print markdown make it just for a single release plural urls and add urls try the stuff Use PointerInterceptor in dialogs to allow clicks over an iFrame (flutter#4578) UX improvement to banner warnings and errors (flutter#3537) * UX improvement to banner warnings and errors * review comments * update goldens Add Use Legacy Trace Viewer setting to the Performance page (flutter#4579) Add button to toggle visibility of the Flutter frames chart (flutter#4577) Bump actions/checkout from 3.0.2 to 3.1.0 (flutter#4574) Bumps [actions/checkout](https://github.com/actions/checkout) from 3.0.2 to 3.1.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@2541b12...93ea575) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Simplify loading data into perfetto iFrame (flutter#4580) Add --update-perfetto option to build scripts (flutter#4581) Add details to diff. (flutter#4549) Include the full path for Perfetto assets (flutter#4585) * Include the full path for Perfetto assets * fix * review comments Improvements for release documentation (flutter#4575) Update feature_flags.dart (flutter#4584) try clone repo try new paths Add case study for memory diffing. (flutter#4589) Build and test DevTools from the latest flutter candidate branch (flutter#4582) Update version tool logic for `dev` versions (flutter#4536) Update CONTRIBUTING.md (flutter#4588) Bump to dev version 2.19.0-dev.0 (flutter#4594) Clicking on file name selects file (flutter#4409) oops cd order this has a higher likelyhood to do the trikc uses seperate :D
CoderDake
pushed a commit
to CoderDake/devtools
that referenced
this pull request
Oct 10, 2022
* UX improvement to banner warnings and errors * review comments * update goldens
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the message on the performance page and cpu profiler page from an "error" to a "warning", and it tweaks the wording of this message. This PR also changes the message style a little bit by using an error/warning icon instead of the words "ERROR" and "WARNING".
(note: this error screenshot is just to show the styling, and the text here is actually shown as a warning - not an error)
@InMatrix @cobblest