Update version tool logic for dev versions
#4536
Conversation
tool/update_version.dart
Outdated
| }, | ||
| mandatory: false, | ||
| defaultsTo: 'minor', | ||
| help: '''Bumps the preparory devtools version by the selected type. |
There was a problem hiding this comment.
I think preparory might be a typo
There was a problem hiding this comment.
Oops! It was indeed, thanks!
tool/update_version.dart
Outdated
| @@ -288,19 +289,34 @@ class AutoUpdateCommand extends Command { | |||
| }, | |||
| mandatory: true, | |||
| help: 'Bumps the devtools version by the selected type.'); | |||
|
|
|||
| argParser.addOption('devType', | |||
There was a problem hiding this comment.
What would you think about us changing 'type' to a multioption instead.
So instead of doing --type dev --devType patch we could do --type dev,patch (as a multioption would allow multiple values to be entered)
then we could have a logic flow, like the following, on the inside.
- Starting version:
2.17.0-
--type dev- Fails with message "no previous dev version defined, please also add patch,minor, or major, to your type selection" (or something to this effect)
-
--type dev,patch- updates to
2.17.1-dev.0
- updates to
-
Starting version:
2.17.0-dev.3 -
--type dev- updates to
2.17.0-dev.4
- updates to
-
--type dev,patch- updates to
2.17.1-dev.0
- updates to
-
There was a problem hiding this comment.
perhaps for the error message when no type is passed along with dev, it could say
Current version 2.17.0 has no dev pre-release. Please use '--type dev,patch' OR '--type dev,minor', OR '--type dev,major' to specify which version you would like to bump
There was a problem hiding this comment.
Sorry, this fell by the wayside! Made the proposed changes, with one change: if only dev is specified, we default to a minor pre-release (instead of showing an error message) since that is the default. We can still specify patch or major versions with dev,patch or dev,major
rename release_note_helper First step towards an official verify :D add verify command add ability to print markdown make it just for a single release plural urls and add urls try the stuff Use PointerInterceptor in dialogs to allow clicks over an iFrame (flutter#4578) UX improvement to banner warnings and errors (flutter#3537) * UX improvement to banner warnings and errors * review comments * update goldens Add Use Legacy Trace Viewer setting to the Performance page (flutter#4579) Add button to toggle visibility of the Flutter frames chart (flutter#4577) Bump actions/checkout from 3.0.2 to 3.1.0 (flutter#4574) Bumps [actions/checkout](https://github.com/actions/checkout) from 3.0.2 to 3.1.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@2541b12...93ea575) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Simplify loading data into perfetto iFrame (flutter#4580) Add --update-perfetto option to build scripts (flutter#4581) Add details to diff. (flutter#4549) Include the full path for Perfetto assets (flutter#4585) * Include the full path for Perfetto assets * fix * review comments Improvements for release documentation (flutter#4575) Update feature_flags.dart (flutter#4584) try clone repo try new paths Add case study for memory diffing. (flutter#4589) Build and test DevTools from the latest flutter candidate branch (flutter#4582) Update version tool logic for `dev` versions (flutter#4536) Update CONTRIBUTING.md (flutter#4588) Bump to dev version 2.19.0-dev.0 (flutter#4594) Clicking on file name selects file (flutter#4409) oops cd order this has a higher likelyhood to do the trikc uses seperate :D
dart tool/update_version.dart auto --type devcreates adevversion for the nextminorversiondevTypearg can be provided to create adevversion for the nextmajororpatchversion instead (eg,dart tool/update_version.dart auto --type dev --devType patch)