Skip to content

Prepare dev release for g3 roll #4530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 27, 2022
Merged

Conversation

elliette
Copy link
Member

I would like to roll DevTools into g3 to fix #4524

Following instructions to prepare dev release here: https://github.com/flutter/devtools/tree/master/tool#prepare-the-release

Ran dart tool/update_version.dart auto --type dev

@@ -1,3 +1,6 @@
## 2.17.0-dev.0
TODO: update changelog
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What should the CHANGELOG look like? Should I remove the TODO? Or generate the changelog (in which case we should update instructions in https://github.com/flutter/devtools/tree/master/tool#prepare-the-release)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think TODO is fine for dev release. The generate changelog tool isn't smart enough to use releases that aren't formally tagged on our repo as a 'before' data for the range of commits. Plus, the release will be going out in a couple of days so this changelog will get updated then.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps we should just leave a bullet mentioning it is a dev release, so there aren't any notes needed?
Leaving todo's implies that something needs to be done and might come up later

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added that to #4536 :)

CHANGELOG.md Outdated
@@ -1,3 +1,6 @@
## 2.17.0-dev.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this version should be 2.18.0-dev.0, as 2.17.0-dev.0 is actually before 2.17.0 in semantic versioning

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might need to be updated in our version bumping script.
if we wanted to make a dev version of 2.17.0 what would you expect the dev version to be?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline! By default we will have the dev version be preparatory for next minor release

Copy link
Member

@kenzieschmoll kenzieschmoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm once version is changed

@elliette elliette merged commit 6735474 into flutter:master Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File opener and search are broken
3 participants