Skip to content

Prepare dev release for g3 roll #4530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 27, 2022
Merged

Prepare dev release for g3 roll #4530

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
443179d
Prepare dev release for g3 roll
elliette Sep 26, 2022
23501df
Update version
elliette Sep 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
## 2.17.0-dev.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this version should be 2.18.0-dev.0, as 2.17.0-dev.0 is actually before 2.17.0 in semantic versioning

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might need to be updated in our version bumping script.
if we wanted to make a dev version of 2.17.0 what would you expect the dev version to be?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline! By default we will have the dev version be preparatory for next minor release

TODO: update changelog
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What should the CHANGELOG look like? Should I remove the TODO? Or generate the changelog (in which case we should update instructions in https://github.com/flutter/devtools/tree/master/tool#prepare-the-release)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think TODO is fine for dev release. The generate changelog tool isn't smart enough to use releases that aren't formally tagged on our repo as a 'before' data for the range of commits. Plus, the release will be going out in a couple of days so this changelog will get updated then.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps we should just leave a bullet mentioning it is a dev release, so there aren't any notes needed?
Leaving todo's implies that something needs to be done and might come up later

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added that to #4536 :)


## 2.17.0
* Prepare for 2.17.0 release [#4428](https://github.com/flutter/devtools/pull/4428)
* Revert perfetto bundle [#4422](https://github.com/flutter/devtools/pull/4422)
Expand Down
2 changes: 1 addition & 1 deletion packages/devtools_app/lib/devtools.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@
// that updates all versions for DevTools.
// Note: a regexp in tools/update_version.dart matches the following line so
// if you change it you must also modify tools/update_version.dart.
const String version = '2.17.0';
const String version = '2.17.0-dev.0';
6 changes: 3 additions & 3 deletions packages/devtools_app/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ publish_to: none

# Note: this version should only be updated by running tools/update_version.dart
# that updates all versions of devtools packages (devtools_app, devtools_test).
version: 2.17.0
version: 2.17.0-dev.0

repository: https://github.com/flutter/devtools/tree/master/packages/devtools_app

Expand All @@ -23,7 +23,7 @@ dependencies:
collection: ^1.15.0
dds: ^2.2.2
dds_service_extensions: ^1.3.1
devtools_shared: 2.17.0
devtools_shared: 2.17.0-dev.0
file: ^6.0.0
file_selector: ^0.8.0
file_selector_linux: ^0.0.2
Expand Down Expand Up @@ -57,7 +57,7 @@ dependencies:

dev_dependencies:
build_runner: ^2.0.4
devtools_test: 2.17.0
devtools_test: 2.17.0-dev.0
flutter_test:
sdk: flutter
mockito: ^5.1.0
Expand Down
2 changes: 1 addition & 1 deletion packages/devtools_app/web/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
application. For more information, see:
https://developers.google.com/web/fundamentals/primers/service-workers -->
<script>
var version = '2.17.0';
var version = '2.17.0-dev.0';
var scriptLoaded = false;
function loadMainDartJs() {
if (scriptLoaded) {
Expand Down
2 changes: 1 addition & 1 deletion packages/devtools_shared/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: devtools_shared
description: Package of shared structures between devtools_app, dds, and other tools.

version: 2.17.0
version: 2.17.0-dev.0

repository: https://github.com/flutter/devtools/tree/master/packages/devtools_shared

Expand Down
6 changes: 3 additions & 3 deletions packages/devtools_test/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ publish_to: none
# When publishing new versions of this package be sure to publish a new version
# of package:devtools as well. package:devtools contains a compiled snapshot of
# this package.
version: 2.17.0
version: 2.17.0-dev.0

repository: https://github.com/flutter/devtools/tree/master/packages/devtools_test

Expand All @@ -18,8 +18,8 @@ environment:
dependencies:
async: ^2.0.0
collection: ^1.15.0
devtools_shared: 2.17.0
devtools_app: 2.17.0
devtools_shared: 2.17.0-dev.0
devtools_app: 2.17.0-dev.0
flutter:
sdk: flutter
flutter_test:
Expand Down