Skip to content

Add details to diff. #4549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 64 commits into from
Oct 6, 2022
Merged

Add details to diff. #4549

merged 64 commits into from
Oct 6, 2022

Conversation

polina-c
Copy link
Contributor

@polina-c polina-c commented Sep 29, 2022

Single snapshot:
Screen Shot 2022-10-05 at 2 09 19 PM

Diff for two snapshots:
Screen Shot 2022-10-05 at 2 09 49 PM

@polina-c polina-c marked this pull request as ready for review September 29, 2022 06:04
Copy link
Member

@kenzieschmoll kenzieschmoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove all files under failures/

@kenzieschmoll
Copy link
Member

can you add a screenshot / gif to the PR description?

@polina-c polina-c marked this pull request as draft September 30, 2022 16:02
@polina-c polina-c marked this pull request as ready for review October 5, 2022 21:03
Copy link
Member

@kenzieschmoll kenzieschmoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm after final comments are addressed. looks good!

@polina-c polina-c merged commit bf471e5 into flutter:master Oct 6, 2022
@polina-c polina-c deleted the details-1 branch October 6, 2022 19:00
CoderDake added a commit to CoderDake/devtools that referenced this pull request Oct 10, 2022
rename release_note_helper

First step towards an official verify :D

add verify command

add ability to print markdown

make it just for a single release

plural urls
and add urls

try the stuff

Use PointerInterceptor in dialogs to allow clicks over an iFrame (flutter#4578)

UX improvement to banner warnings and errors (flutter#3537)

* UX improvement to banner warnings and errors

* review comments

* update goldens

Add Use Legacy Trace Viewer setting to the Performance page (flutter#4579)

Add button to toggle visibility of the Flutter frames chart (flutter#4577)

Bump actions/checkout from 3.0.2 to 3.1.0 (flutter#4574)

Bumps [actions/checkout](https://github.com/actions/checkout) from 3.0.2 to 3.1.0.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@2541b12...93ea575)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Simplify loading data into perfetto iFrame (flutter#4580)

Add --update-perfetto option to build scripts (flutter#4581)

Add details to diff. (flutter#4549)

Include the full path for Perfetto assets (flutter#4585)

* Include the full path for Perfetto assets

* fix

* review comments

Improvements for release documentation (flutter#4575)

Update feature_flags.dart (flutter#4584)

try clone repo

try new paths

Add case study for memory diffing. (flutter#4589)

Build and test DevTools from the latest flutter candidate branch (flutter#4582)

Update version tool logic for `dev` versions (flutter#4536)

Update CONTRIBUTING.md (flutter#4588)

Bump to dev version 2.19.0-dev.0 (flutter#4594)

Clicking on file name selects file (flutter#4409)

oops cd order

this has a higher likelyhood to do the trikc

uses seperate  :D
CoderDake pushed a commit to CoderDake/devtools that referenced this pull request Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants