This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Refactor MacOS to use Compositor to create backing stores using FlutterSurfaceManager #22500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RichardJCai
force-pushed
the
compositor_with_fsm
branch
3 times, most recently
from
5ffd44e to
4cd6408
Compare
RichardJCai
changed the title
RichardJCai
force-pushed
the
compositor_with_fsm
branch
from
4cd6408 to
d5dfc8c
Compare
iskakaushik
suggested changes
Nov 16, 2020
shell/platform/darwin/macos/framework/Source/FlutterMacOSGLCompositor.mm
Outdated
Show resolved
Hide resolved
shell/platform/darwin/macos/framework/Source/FlutterMacOSGLCompositor.mm
Outdated
Show resolved
Hide resolved
shell/platform/darwin/macos/framework/Source/FlutterMacOSGLCompositor.mm
Outdated
Show resolved
Hide resolved
shell/platform/darwin/macos/framework/Source/FlutterMacOSGLCompositor.mm
Show resolved
Hide resolved
shell/platform/darwin/macos/framework/Source/FlutterSurfaceManager.h
Outdated
Show resolved
Hide resolved
shell/platform/darwin/macos/framework/Source/FlutterSurfaceManager.mm
Outdated
Show resolved
Hide resolved
cyanglaz
reviewed
Nov 16, 2020
shell/platform/darwin/macos/framework/Source/FlutterMacOSGLCompositor.mm
Outdated
Show resolved
Hide resolved
shell/platform/darwin/macos/framework/Source/FlutterSurfaceManager.h
Outdated
Show resolved
Hide resolved
shell/platform/darwin/macos/framework/Source/MockFlutterViewController.h
Outdated
Show resolved
Hide resolved
RichardJCai
force-pushed
the
compositor_with_fsm
branch
3 times, most recently
from
c99ae44 to
ebb0657
Compare
iskakaushik
reviewed
Nov 16, 2020
shell/platform/darwin/macos/framework/Source/FlutterMacOSGLCompositor.mm
Outdated
Show resolved
Hide resolved
cyanglaz
reviewed
Nov 16, 2020
shell/platform/darwin/macos/framework/Source/FlutterSurfaceManager.mm
Outdated
Show resolved
Hide resolved
RichardJCai
force-pushed
the
compositor_with_fsm
branch
2 times, most recently
from
1696d63 to
cde9c1b
Compare
…res using FlutterSurfaceManager.
RichardJCai
force-pushed
the
compositor_with_fsm
branch
from
cde9c1b to
0177f9e
Compare
iskakaushik
reviewed
Nov 16, 2020
iskakaushik
reviewed
Nov 16, 2020
iskakaushik
reviewed
Nov 16, 2020
iskakaushik
reviewed
Nov 16, 2020
iskakaushik
reviewed
Nov 16, 2020
shell/platform/darwin/macos/framework/Source/FlutterMacOSGLCompositor.h
Outdated
Show resolved
Hide resolved
iskakaushik
reviewed
Nov 16, 2020
shell/platform/darwin/macos/framework/Source/FlutterMacOSGLCompositor.h
Outdated
Show resolved
Hide resolved
iskakaushik
reviewed
Nov 16, 2020
shell/platform/darwin/macos/framework/Source/FlutterMacOSGLCompositor.h
Outdated
Show resolved
Hide resolved
iskakaushik
reviewed
Nov 16, 2020
shell/platform/darwin/macos/framework/Source/FlutterMacOSGLCompositor.h
Outdated
Show resolved
Hide resolved
iskakaushik
reviewed
Nov 16, 2020
shell/platform/darwin/macos/framework/Source/FlutterMacOSGLCompositor.h
Outdated
Show resolved
Hide resolved
iskakaushik
reviewed
Nov 16, 2020
iskakaushik
reviewed
Nov 16, 2020
shell/platform/darwin/macos/framework/Source/FlutterMacOSGLCompositor.mm
Outdated
Show resolved
Hide resolved
iskakaushik
reviewed
Nov 16, 2020
| ASSERT_TRUE(macos_compositor->Present(nil, 0)); | ||
| ASSERT_TRUE(flag); | ||
| } | ||
|
|
There was a problem hiding this comment.
add a test to ensure after collect backing store gets called, we invoke the destructor.
RichardJCai
force-pushed
the
compositor_with_fsm
branch
from
72b0c4b to
d190399
Compare
RichardJCai
force-pushed
the
compositor_with_fsm
branch
from
d190399 to
1a3a6d2
Compare
cyanglaz
reviewed
Nov 18, 2020
shell/platform/darwin/macos/framework/Source/FlutterSurfaceManager.mm
Outdated
Show resolved
Hide resolved
RichardJCai
force-pushed
the
compositor_with_fsm
branch
from
a79585f to
01d75bd
Compare
…form view in the layer tree. Otherwise the current render path will be used. This is to avoid regression as Compositor currently doesn't fully support resizing.
RichardJCai
force-pushed
the
compositor_with_fsm
branch
from
01d75bd to
48e4362
Compare
|
Closing this in favor of smaller PRs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating FlutterMacOSCompositor and use FlutterSurfaceManager to provide backing stores.
This will allow us to add Platform view support for MacOS through future changes to FlutterMacOSCompositor.