This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Create wrapper for IOSurface #22663
Merged
Create wrapper for IOSurface #22663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
iskakaushik
reviewed
Nov 21, 2020
shell/platform/darwin/macos/framework/Source/FlutterIOSurfaceWrapper.mm
Outdated
Show resolved
Hide resolved
RichardJCai
force-pushed
the
io_surface_wrapper
branch
2 times, most recently
from
38161b8 to
071af65
Compare
iskakaushik
reviewed
Nov 23, 2020
shell/platform/darwin/macos/framework/Source/FlutterIOSurfaceHolder.h
Outdated
Show resolved
Hide resolved
iskakaushik
reviewed
Nov 23, 2020
shell/platform/darwin/macos/framework/Source/FlutterIOSurfaceHolder.h
Outdated
Show resolved
Hide resolved
iskakaushik
reviewed
Nov 23, 2020
shell/platform/darwin/macos/framework/Source/FlutterSurfaceManager.mm
Outdated
Show resolved
Hide resolved
RichardJCai
force-pushed
the
io_surface_wrapper
branch
from
071af65 to
155ac22
Compare
binding IOSurfaces to textures / framebuffers.
RichardJCai
force-pushed
the
io_surface_wrapper
branch
from
155ac22 to
1dd6d16
Compare
This was referenced Nov 23, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 24, 2020
chaselatta
pushed a commit
to chaselatta/engine
that referenced
this pull request
Nov 30, 2020
binding IOSurfaces to textures / framebuffers.
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tentatively named IOSurfaceWrapper.
Create a wrapper for IOSurface to handle creation and binding IOSurfaces to textures / framebuffers.
Decouple IOSurface logic from FlutterSurfaceManager.
Depends on #22656