This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Create FlutterFrameBufferProvider class #22656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
RichardJCai
force-pushed
the
flutter_frame_buffer_provider
branch
from
d3a163c to
17b5dcc
Compare
Refactor FlutterSurfaceManager to use FlutterFrameBufferProvider. FlutterFrameBufferProvider will be used to uncouple FlutterGLCompositor for MacOS and FlutterSurfaceManager.
RichardJCai
force-pushed
the
flutter_frame_buffer_provider
branch
from
17b5dcc to
89b1746
Compare
iskakaushik
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 24, 2020
chaselatta
pushed a commit
to chaselatta/engine
that referenced
this pull request
Nov 30, 2020
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create FlutterFrameBufferProvider class.
FlutterFrameBufferProvider will handle creating framebuffers and their backing textures.
Refactor FlutterSurfaceManager to use FlutterFrameBufferProvider.
FlutterFrameBufferProvider will be used to uncouple FlutterGLCompositor forMacOS and FlutterSurfaceManager.