This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] add triangle fan support and remove drawVertices copying. #55236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Sep 23, 2024
| @@ -159,6 +159,9 @@ constexpr MTLPrimitiveType ToMTLPrimitiveType(PrimitiveType type) { | |||
| return MTLPrimitiveTypeLineStrip; | |||
| case PrimitiveType::kPoint: | |||
| return MTLPrimitiveTypePoint; | |||
| case PrimitiveType::kTriangleFan: | |||
| // UNSUPPORTED | |||
There was a problem hiding this comment.
Can we update this comment to say that callers are expected to perform a cap check.
|
|
||
| const std::shared_ptr<const flutter::DlVertices> vertices_; | ||
| std::vector<uint16_t> indices_; | ||
| bool performed_normalization_; |
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 23, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 23, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 24, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 24, 2024
…155583) flutter/engine@95c5a09...8a5af19 2024-09-23 [email protected] Roll Skia from 7174ab7a984d to 7b0669f89aef (1 revision) (flutter/engine#55371) 2024-09-23 [email protected] [Impeller] Fix GLES gaussian implementation. (flutter/engine#55329) 2024-09-23 [email protected] Made YAML version of vscode workspace to avoid redundancy (flutter/engine#55322) 2024-09-23 [email protected] Roll Skia from acb93a9f241f to 7174ab7a984d (6 revisions) (flutter/engine#55369) 2024-09-23 [email protected] [Impeller] add triangle fan support and remove drawVertices copying. (flutter/engine#55236) 2024-09-23 [email protected] Copy Dart SDK vm_shared sources into the sky_engine package (flutter/engine#55158) 2024-09-23 [email protected] [Impeller] use BufferSubData to update gles device buffer. (flutter/engine#55330) 2024-09-23 [email protected] [Impeller] remove usage of VBB when allocating vertices of a fixed size. (flutter/engine#55235) 2024-09-23 6844906[email protected] [fuchsia] Update fuchsia instruction in Compiling-the-engine.md (flutter/engine#55365) 2024-09-23 [email protected] [iOS] sprinkle some null checks on BringLayersIntoView. (flutter/engine#55334) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
thejitenpatel
pushed a commit
to thejitenpatel/flutter
that referenced
this pull request
Sep 26, 2024
…lutter#155583) flutter/engine@95c5a09...8a5af19 2024-09-23 [email protected] Roll Skia from 7174ab7a984d to 7b0669f89aef (1 revision) (flutter/engine#55371) 2024-09-23 [email protected] [Impeller] Fix GLES gaussian implementation. (flutter/engine#55329) 2024-09-23 [email protected] Made YAML version of vscode workspace to avoid redundancy (flutter/engine#55322) 2024-09-23 [email protected] Roll Skia from acb93a9f241f to 7174ab7a984d (6 revisions) (flutter/engine#55369) 2024-09-23 [email protected] [Impeller] add triangle fan support and remove drawVertices copying. (flutter/engine#55236) 2024-09-23 [email protected] Copy Dart SDK vm_shared sources into the sky_engine package (flutter/engine#55158) 2024-09-23 [email protected] [Impeller] use BufferSubData to update gles device buffer. (flutter/engine#55330) 2024-09-23 [email protected] [Impeller] remove usage of VBB when allocating vertices of a fixed size. (flutter/engine#55235) 2024-09-23 6844906[email protected] [fuchsia] Update fuchsia instruction in Compiling-the-engine.md (flutter/engine#55365) 2024-09-23 [email protected] [iOS] sprinkle some null checks on BringLayersIntoView. (flutter/engine#55334) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
thejitenpatel
pushed a commit
to thejitenpatel/flutter
that referenced
this pull request
Sep 26, 2024
…lutter#155583) flutter/engine@95c5a09...8a5af19 2024-09-23 [email protected] Roll Skia from 7174ab7a984d to 7b0669f89aef (1 revision) (flutter/engine#55371) 2024-09-23 [email protected] [Impeller] Fix GLES gaussian implementation. (flutter/engine#55329) 2024-09-23 [email protected] Made YAML version of vscode workspace to avoid redundancy (flutter/engine#55322) 2024-09-23 [email protected] Roll Skia from acb93a9f241f to 7174ab7a984d (6 revisions) (flutter/engine#55369) 2024-09-23 [email protected] [Impeller] add triangle fan support and remove drawVertices copying. (flutter/engine#55236) 2024-09-23 [email protected] Copy Dart SDK vm_shared sources into the sky_engine package (flutter/engine#55158) 2024-09-23 [email protected] [Impeller] use BufferSubData to update gles device buffer. (flutter/engine#55330) 2024-09-23 [email protected] [Impeller] remove usage of VBB when allocating vertices of a fixed size. (flutter/engine#55235) 2024-09-23 6844906[email protected] [fuchsia] Update fuchsia instruction in Compiling-the-engine.md (flutter/engine#55365) 2024-09-23 [email protected] [iOS] sprinkle some null checks on BringLayersIntoView. (flutter/engine#55334) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
thejitenpatel
pushed a commit
to thejitenpatel/flutter
that referenced
this pull request
Sep 27, 2024
…lutter#155583) flutter/engine@95c5a09...8a5af19 2024-09-23 [email protected] Roll Skia from 7174ab7a984d to 7b0669f89aef (1 revision) (flutter/engine#55371) 2024-09-23 [email protected] [Impeller] Fix GLES gaussian implementation. (flutter/engine#55329) 2024-09-23 [email protected] Made YAML version of vscode workspace to avoid redundancy (flutter/engine#55322) 2024-09-23 [email protected] Roll Skia from acb93a9f241f to 7174ab7a984d (6 revisions) (flutter/engine#55369) 2024-09-23 [email protected] [Impeller] add triangle fan support and remove drawVertices copying. (flutter/engine#55236) 2024-09-23 [email protected] Copy Dart SDK vm_shared sources into the sky_engine package (flutter/engine#55158) 2024-09-23 [email protected] [Impeller] use BufferSubData to update gles device buffer. (flutter/engine#55330) 2024-09-23 [email protected] [Impeller] remove usage of VBB when allocating vertices of a fixed size. (flutter/engine#55235) 2024-09-23 6844906[email protected] [fuchsia] Update fuchsia instruction in Compiling-the-engine.md (flutter/engine#55365) 2024-09-23 [email protected] [iOS] sprinkle some null checks on BringLayersIntoView. (flutter/engine#55334) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
thejitenpatel
pushed a commit
to thejitenpatel/flutter
that referenced
this pull request
Sep 27, 2024
…lutter#155583) flutter/engine@95c5a09...8a5af19 2024-09-23 [email protected] Roll Skia from 7174ab7a984d to 7b0669f89aef (1 revision) (flutter/engine#55371) 2024-09-23 [email protected] [Impeller] Fix GLES gaussian implementation. (flutter/engine#55329) 2024-09-23 [email protected] Made YAML version of vscode workspace to avoid redundancy (flutter/engine#55322) 2024-09-23 [email protected] Roll Skia from acb93a9f241f to 7174ab7a984d (6 revisions) (flutter/engine#55369) 2024-09-23 [email protected] [Impeller] add triangle fan support and remove drawVertices copying. (flutter/engine#55236) 2024-09-23 [email protected] Copy Dart SDK vm_shared sources into the sky_engine package (flutter/engine#55158) 2024-09-23 [email protected] [Impeller] use BufferSubData to update gles device buffer. (flutter/engine#55330) 2024-09-23 [email protected] [Impeller] remove usage of VBB when allocating vertices of a fixed size. (flutter/engine#55235) 2024-09-23 6844906[email protected] [fuchsia] Update fuchsia instruction in Compiling-the-engine.md (flutter/engine#55365) 2024-09-23 [email protected] [iOS] sprinkle some null checks on BringLayersIntoView. (flutter/engine#55334) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vulkan and GLES backends support triangle fans, so only "un-fan" these geometries when necessary. Now that dispatch gives the vertices geometry as a shared_ptr, we can hold onto that directly without performing another copy.