Made YAML version of vscode workspace to avoid redundancy #55322

gaaclarke · 2024-09-20T20:38:30Z

In #55291 we added a vscode workspace to help with running tests and sharing settings. However, VSCode does not support a config format that has the ability to reduce redundancy and it will get quite unwieldy as we add in all of the engines test runners. To combat that I've added instead a YAML config that can converted to JSON for VSCode.

This also adds 2 more test runners: display_list_unittests and impeller_golden_tests

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
I listed at least one issue that this PR fixes in the description above.
I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
I updated/added relevant documentation (doc comments with ///).
I signed the CLA.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

flutter-dashboard · 2024-09-20T20:38:33Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

gaaclarke · 2024-09-20T20:38:53Z

engine.code-workspace

      }
    ]
  },
  "extensions": {
    "recommendations": [
-      // C++ TestMate


These comments live in the yaml file now.

gaaclarke · 2024-09-20T20:39:32Z

tools/vscode_workspace/engine-workspace.yaml

+        clear: true
+      group:
+        kind: build
+    - <<: *et-task


Here's one place where the magic is happening.

Just checking; workspaceFolder didn't seem to work for my regular .vscode configs; does it work in the engine-workspace?

It won't work unless you open up a workspace (//engine.code-workspace).

jtmcdole · 2024-09-23T19:32:58Z

tools/vscode_workspace/engine-workspace.yaml

+        clear: true
+      group:
+        kind: build
+    - <<: *et-task


Just checking; workspaceFolder didn't seem to work for my regular .vscode configs; does it work in the engine-workspace?

tools/vscode_workspace/merge.sh

…lutter/engine#55322)

…155583) flutter/engine@95c5a09...8a5af19 2024-09-23 [email protected] Roll Skia from 7174ab7a984d to 7b0669f89aef (1 revision) (flutter/engine#55371) 2024-09-23 [email protected] [Impeller] Fix GLES gaussian implementation. (flutter/engine#55329) 2024-09-23 [email protected] Made YAML version of vscode workspace to avoid redundancy (flutter/engine#55322) 2024-09-23 [email protected] Roll Skia from acb93a9f241f to 7174ab7a984d (6 revisions) (flutter/engine#55369) 2024-09-23 [email protected] [Impeller] add triangle fan support and remove drawVertices copying. (flutter/engine#55236) 2024-09-23 [email protected] Copy Dart SDK vm_shared sources into the sky_engine package (flutter/engine#55158) 2024-09-23 [email protected] [Impeller] use BufferSubData to update gles device buffer. (flutter/engine#55330) 2024-09-23 [email protected] [Impeller] remove usage of VBB when allocating vertices of a fixed size. (flutter/engine#55235) 2024-09-23 6844906[email protected] [fuchsia] Update fuchsia instruction in Compiling-the-engine.md (flutter/engine#55365) 2024-09-23 [email protected] [iOS] sprinkle some null checks on BringLayersIntoView. (flutter/engine#55334) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…lutter#155583) flutter/engine@95c5a09...8a5af19 2024-09-23 [email protected] Roll Skia from 7174ab7a984d to 7b0669f89aef (1 revision) (flutter/engine#55371) 2024-09-23 [email protected] [Impeller] Fix GLES gaussian implementation. (flutter/engine#55329) 2024-09-23 [email protected] Made YAML version of vscode workspace to avoid redundancy (flutter/engine#55322) 2024-09-23 [email protected] Roll Skia from acb93a9f241f to 7174ab7a984d (6 revisions) (flutter/engine#55369) 2024-09-23 [email protected] [Impeller] add triangle fan support and remove drawVertices copying. (flutter/engine#55236) 2024-09-23 [email protected] Copy Dart SDK vm_shared sources into the sky_engine package (flutter/engine#55158) 2024-09-23 [email protected] [Impeller] use BufferSubData to update gles device buffer. (flutter/engine#55330) 2024-09-23 [email protected] [Impeller] remove usage of VBB when allocating vertices of a fixed size. (flutter/engine#55235) 2024-09-23 6844906[email protected] [fuchsia] Update fuchsia instruction in Compiling-the-engine.md (flutter/engine#55365) 2024-09-23 [email protected] [iOS] sprinkle some null checks on BringLayersIntoView. (flutter/engine#55334) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Made YAML version of vscode workspace to avoid redundancy

66137c4

gaaclarke commented Sep 20, 2024

View reviewed changes

gaaclarke requested review from jtmcdole and matanlurey September 20, 2024 20:40

gaaclarke mentioned this pull request Sep 20, 2024

Adds tools/json_injector #55309

Closed

8 tasks

gaaclarke added 6 commits September 20, 2024 14:08

pulled out source map cmd

8d674d7

made building silent

7c3b1de

refresh

56be4bf

added script for merging

d8e7451

removed stray comment

4c97241

added ios build

6f57bec

jtmcdole reviewed Sep 23, 2024

View reviewed changes

added requirements section to readme.md

8ae217f

gaaclarke requested a review from jtmcdole September 23, 2024 19:56

oops

ca0958a

jtmcdole approved these changes Sep 23, 2024

View reviewed changes

gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 23, 2024

auto-submit bot merged commit e6dd280 into flutter:main Sep 23, 2024
32 checks passed

engine-flutter-autoroll mentioned this pull request Sep 23, 2024

Roll Flutter Engine from 9bb0ece79ae2 to e6dd280d6956 (10 revisions) flutter/flutter#155577

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 23, 2024

e6dd280d6 Made YAML version of vscode workspace to avoid redundancy (f…

7fff354

…lutter/engine#55322)

engine-flutter-autoroll mentioned this pull request Sep 24, 2024

Roll Flutter Engine from 95c5a0940ad9 to 8a5af19a43f3 (10 revisions) flutter/flutter#155583

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 24, 2024

e6dd280d6 Made YAML version of vscode workspace to avoid redundancy (f…

781d561

…lutter/engine#55322)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Made YAML version of vscode workspace to avoid redundancy #55322

Made YAML version of vscode workspace to avoid redundancy #55322

Uh oh!

gaaclarke commented Sep 20, 2024 •

edited

Loading

Uh oh!

flutter-dashboard bot commented Sep 20, 2024

Uh oh!

gaaclarke Sep 20, 2024

Uh oh!

gaaclarke Sep 20, 2024

Uh oh!

jtmcdole Sep 23, 2024

Uh oh!

gaaclarke Sep 23, 2024

Uh oh!

jtmcdole Sep 23, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Made YAML version of vscode workspace to avoid redundancy #55322

Made YAML version of vscode workspace to avoid redundancy #55322

Uh oh!

Conversation

gaaclarke commented Sep 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented Sep 20, 2024

Uh oh!

gaaclarke Sep 20, 2024

Choose a reason for hiding this comment

Uh oh!

gaaclarke Sep 20, 2024

Choose a reason for hiding this comment

Uh oh!

jtmcdole Sep 23, 2024

Choose a reason for hiding this comment

Uh oh!

gaaclarke Sep 23, 2024

Choose a reason for hiding this comment

Uh oh!

jtmcdole Sep 23, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gaaclarke commented Sep 20, 2024 •

edited

Loading