This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[fuchsia] Update fuchsia instruction in Compiling-the-engine.md #55365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Sep 23, 2024
|
I believe you are a contributor already. Please land this when able. Also happy to land this for you. |
|
Yes, I am. I am waiting for the checks. Thank you, Chinmay. |
zijiehe-google-com
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 23, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 23, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 23, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 24, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 24, 2024
…155583) flutter/engine@95c5a09...8a5af19 2024-09-23 [email protected] Roll Skia from 7174ab7a984d to 7b0669f89aef (1 revision) (flutter/engine#55371) 2024-09-23 [email protected] [Impeller] Fix GLES gaussian implementation. (flutter/engine#55329) 2024-09-23 [email protected] Made YAML version of vscode workspace to avoid redundancy (flutter/engine#55322) 2024-09-23 [email protected] Roll Skia from acb93a9f241f to 7174ab7a984d (6 revisions) (flutter/engine#55369) 2024-09-23 [email protected] [Impeller] add triangle fan support and remove drawVertices copying. (flutter/engine#55236) 2024-09-23 [email protected] Copy Dart SDK vm_shared sources into the sky_engine package (flutter/engine#55158) 2024-09-23 [email protected] [Impeller] use BufferSubData to update gles device buffer. (flutter/engine#55330) 2024-09-23 [email protected] [Impeller] remove usage of VBB when allocating vertices of a fixed size. (flutter/engine#55235) 2024-09-23 6844906[email protected] [fuchsia] Update fuchsia instruction in Compiling-the-engine.md (flutter/engine#55365) 2024-09-23 [email protected] [iOS] sprinkle some null checks on BringLayersIntoView. (flutter/engine#55334) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
thejitenpatel
pushed a commit
to thejitenpatel/flutter
that referenced
this pull request
Sep 26, 2024
…lutter#155583) flutter/engine@95c5a09...8a5af19 2024-09-23 [email protected] Roll Skia from 7174ab7a984d to 7b0669f89aef (1 revision) (flutter/engine#55371) 2024-09-23 [email protected] [Impeller] Fix GLES gaussian implementation. (flutter/engine#55329) 2024-09-23 [email protected] Made YAML version of vscode workspace to avoid redundancy (flutter/engine#55322) 2024-09-23 [email protected] Roll Skia from acb93a9f241f to 7174ab7a984d (6 revisions) (flutter/engine#55369) 2024-09-23 [email protected] [Impeller] add triangle fan support and remove drawVertices copying. (flutter/engine#55236) 2024-09-23 [email protected] Copy Dart SDK vm_shared sources into the sky_engine package (flutter/engine#55158) 2024-09-23 [email protected] [Impeller] use BufferSubData to update gles device buffer. (flutter/engine#55330) 2024-09-23 [email protected] [Impeller] remove usage of VBB when allocating vertices of a fixed size. (flutter/engine#55235) 2024-09-23 6844906[email protected] [fuchsia] Update fuchsia instruction in Compiling-the-engine.md (flutter/engine#55365) 2024-09-23 [email protected] [iOS] sprinkle some null checks on BringLayersIntoView. (flutter/engine#55334) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
thejitenpatel
pushed a commit
to thejitenpatel/flutter
that referenced
this pull request
Sep 26, 2024
…lutter#155583) flutter/engine@95c5a09...8a5af19 2024-09-23 [email protected] Roll Skia from 7174ab7a984d to 7b0669f89aef (1 revision) (flutter/engine#55371) 2024-09-23 [email protected] [Impeller] Fix GLES gaussian implementation. (flutter/engine#55329) 2024-09-23 [email protected] Made YAML version of vscode workspace to avoid redundancy (flutter/engine#55322) 2024-09-23 [email protected] Roll Skia from acb93a9f241f to 7174ab7a984d (6 revisions) (flutter/engine#55369) 2024-09-23 [email protected] [Impeller] add triangle fan support and remove drawVertices copying. (flutter/engine#55236) 2024-09-23 [email protected] Copy Dart SDK vm_shared sources into the sky_engine package (flutter/engine#55158) 2024-09-23 [email protected] [Impeller] use BufferSubData to update gles device buffer. (flutter/engine#55330) 2024-09-23 [email protected] [Impeller] remove usage of VBB when allocating vertices of a fixed size. (flutter/engine#55235) 2024-09-23 6844906[email protected] [fuchsia] Update fuchsia instruction in Compiling-the-engine.md (flutter/engine#55365) 2024-09-23 [email protected] [iOS] sprinkle some null checks on BringLayersIntoView. (flutter/engine#55334) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
thejitenpatel
pushed a commit
to thejitenpatel/flutter
that referenced
this pull request
Sep 27, 2024
…lutter#155583) flutter/engine@95c5a09...8a5af19 2024-09-23 [email protected] Roll Skia from 7174ab7a984d to 7b0669f89aef (1 revision) (flutter/engine#55371) 2024-09-23 [email protected] [Impeller] Fix GLES gaussian implementation. (flutter/engine#55329) 2024-09-23 [email protected] Made YAML version of vscode workspace to avoid redundancy (flutter/engine#55322) 2024-09-23 [email protected] Roll Skia from acb93a9f241f to 7174ab7a984d (6 revisions) (flutter/engine#55369) 2024-09-23 [email protected] [Impeller] add triangle fan support and remove drawVertices copying. (flutter/engine#55236) 2024-09-23 [email protected] Copy Dart SDK vm_shared sources into the sky_engine package (flutter/engine#55158) 2024-09-23 [email protected] [Impeller] use BufferSubData to update gles device buffer. (flutter/engine#55330) 2024-09-23 [email protected] [Impeller] remove usage of VBB when allocating vertices of a fixed size. (flutter/engine#55235) 2024-09-23 6844906[email protected] [fuchsia] Update fuchsia instruction in Compiling-the-engine.md (flutter/engine#55365) 2024-09-23 [email protected] [iOS] sprinkle some null checks on BringLayersIntoView. (flutter/engine#55334) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
thejitenpatel
pushed a commit
to thejitenpatel/flutter
that referenced
this pull request
Sep 27, 2024
…lutter#155583) flutter/engine@95c5a09...8a5af19 2024-09-23 [email protected] Roll Skia from 7174ab7a984d to 7b0669f89aef (1 revision) (flutter/engine#55371) 2024-09-23 [email protected] [Impeller] Fix GLES gaussian implementation. (flutter/engine#55329) 2024-09-23 [email protected] Made YAML version of vscode workspace to avoid redundancy (flutter/engine#55322) 2024-09-23 [email protected] Roll Skia from acb93a9f241f to 7174ab7a984d (6 revisions) (flutter/engine#55369) 2024-09-23 [email protected] [Impeller] add triangle fan support and remove drawVertices copying. (flutter/engine#55236) 2024-09-23 [email protected] Copy Dart SDK vm_shared sources into the sky_engine package (flutter/engine#55158) 2024-09-23 [email protected] [Impeller] use BufferSubData to update gles device buffer. (flutter/engine#55330) 2024-09-23 [email protected] [Impeller] remove usage of VBB when allocating vertices of a fixed size. (flutter/engine#55235) 2024-09-23 6844906[email protected] [fuchsia] Update fuchsia instruction in Compiling-the-engine.md (flutter/engine#55365) 2024-09-23 [email protected] [iOS] sprinkle some null checks on BringLayersIntoView. (flutter/engine#55334) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Behavior of
gclient config --custom-vargot changed, modifying the instruction to edit the raw.gclientfile to avoid unexpected gclient behavior.Rich diff: https://github.com/flutter/engine/pull/55365/files?short_path=355a854#diff-355a854159c6f6da4e4e296d0cceb1e7e32ef26af1598aa6cdfaafbdbc656b57
Or rendered md: https://github.com/flutter/engine/blob/b375b805f9bbf478c1618dd0d03a02a11d4e65ab/docs/contributing/Compiling-the-engine.md#compiling-for-fuchsia
Bug: http://b/368770157
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.