-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[webview_flutter_android][webview_flutter_wkwebview] Fixes unawaited_futures violations #4354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartmorgan-g
approved these changes
Jun 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 7, 2023
…awaited_futures violations (flutter/packages#4354)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 7, 2023
flutter/packages@771ec9b...9bcf4bf 2023-07-07 [email protected] [ci] Add LUCI web platform tests (flutter/packages#4391) 2023-07-07 [email protected] [webview_flutter] Enable unawaited_futures lint (flutter/packages#4271) 2023-07-07 [email protected] [ci] Add partial LUCI version of repo_checks (flutter/packages#4389) 2023-07-06 49699333+dependabot[bot]@users.noreply.github.com Bump ossf/scorecard-action from 2.1.3 to 2.2.0 (flutter/packages#4302) 2023-07-06 [email protected] [webview_flutter_android][webview_flutter_wkwebview] Fixes unawaited_futures violations (flutter/packages#4354) 2023-07-06 [email protected] [local_auth] Update Windows Pigeon version (flutter/packages#4388) 2023-07-06 [email protected] [url_launcher] Remove nested third_party safari checker (flutter/packages#4330) 2023-07-06 [email protected] [ci] Add partial LUCI Android platform tests (flutter/packages#4381) 2023-07-06 [email protected] [ci] Switch `master` Linux custom package tests to LUCI (flutter/packages#4386) 2023-07-06 [email protected] [go_router] Exposes package-level privates (flutter/packages#4380) 2023-07-06 [email protected] [file_selector] Update to 1.0 (flutter/packages#4362) 2023-07-06 [email protected] Roll Flutter from 35085c3 to bc49cd1 (14 revisions) (flutter/packages#4387) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced Jul 7, 2023
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
autosubmit
Merge PR when tree becomes green via auto submit App
p: webview_flutter
platform-android
platform-ios
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For flutter/flutter#127323
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.