[go_router] Exposes package-level privates #4380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chunhtai
commented
Jul 5, 2023
| @@ -26,7 +25,6 @@ class GoRouterDelegate extends RouterDelegate<RouteMatchList> | |||
| required GoRouterWidgetBuilder? errorBuilder, | |||
| required List<NavigatorObserver> observers, | |||
| required this.routerNeglect, | |||
| required this.onException, | |||
There was a problem hiding this comment.
This was a mistake I made earlier. this property is unused
johnpryan
approved these changes
Jul 5, 2023
ahmednfwela
reviewed
Jul 5, 2023
| @@ -295,9 +295,6 @@ class GoRouter implements RouterConfig<RouteMatchList> { | |||
| @override | |||
| late final GoRouteInformationParser routeInformationParser; | |||
|
|
|||
| /// Returns `true` if there is at least two or more route can be pop. | |||
| bool canPop() => routerDelegate.canPop(); | |||
There was a problem hiding this comment.
why was this removed while pop is still there?
There was a problem hiding this comment.
you are right, I keep thinking this as a state that should be remove, but it is actually needed for pop as well.
There was a problem hiding this comment.
added it back and updated migration guide
There was a problem hiding this comment.
@chunhtai Also consider correcting CHANGELOG.md for v9.0.0
chunhtai
added
autosubmit
chunhtai
added
the
autosubmit
2 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 7, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 7, 2023
flutter/packages@771ec9b...9bcf4bf 2023-07-07 [email protected] [ci] Add LUCI web platform tests (flutter/packages#4391) 2023-07-07 [email protected] [webview_flutter] Enable unawaited_futures lint (flutter/packages#4271) 2023-07-07 [email protected] [ci] Add partial LUCI version of repo_checks (flutter/packages#4389) 2023-07-06 49699333+dependabot[bot]@users.noreply.github.com Bump ossf/scorecard-action from 2.1.3 to 2.2.0 (flutter/packages#4302) 2023-07-06 [email protected] [webview_flutter_android][webview_flutter_wkwebview] Fixes unawaited_futures violations (flutter/packages#4354) 2023-07-06 [email protected] [local_auth] Update Windows Pigeon version (flutter/packages#4388) 2023-07-06 [email protected] [url_launcher] Remove nested third_party safari checker (flutter/packages#4330) 2023-07-06 [email protected] [ci] Add partial LUCI Android platform tests (flutter/packages#4381) 2023-07-06 [email protected] [ci] Switch `master` Linux custom package tests to LUCI (flutter/packages#4386) 2023-07-06 [email protected] [go_router] Exposes package-level privates (flutter/packages#4380) 2023-07-06 [email protected] [file_selector] Update to 1.0 (flutter/packages#4362) 2023-07-06 [email protected] Roll Flutter from 35085c3 to bc49cd1 (14 revisions) (flutter/packages#4387) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced Jul 7, 2023
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.