Skip to content

[local_auth] Update Windows Pigeon version #4388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

stuartmorgan-g
Copy link
Contributor

Updates to the latest version of Pigeon.

This is largely a no-op, the generated output changes are formatting tweaks and picking up one bugfix to the error code/message ordering. The goal here is just to be using a newer version of Pigeon to minimize future dependency issues along the lines of #4383

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

Updates to the latest version of Pigeon.
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@Hixie
Copy link
Contributor

Hixie commented Jul 6, 2023

test-exempt: rolling dependency

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 6, 2023
@auto-submit auto-submit bot merged commit 3fec7e8 into flutter:main Jul 6, 2023
@stuartmorgan-g stuartmorgan-g deleted the local-auth-windows-pigeon-roll branch July 6, 2023 22:51
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 7, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jul 7, 2023
flutter/packages@771ec9b...9bcf4bf

2023-07-07 [email protected] [ci] Add LUCI web platform tests (flutter/packages#4391)
2023-07-07 [email protected] [webview_flutter] Enable unawaited_futures lint (flutter/packages#4271)
2023-07-07 [email protected] [ci] Add partial LUCI version of repo_checks (flutter/packages#4389)
2023-07-06 49699333+dependabot[bot]@users.noreply.github.com Bump ossf/scorecard-action from 2.1.3 to 2.2.0 (flutter/packages#4302)
2023-07-06 [email protected] [webview_flutter_android][webview_flutter_wkwebview] Fixes unawaited_futures violations (flutter/packages#4354)
2023-07-06 [email protected] [local_auth] Update Windows Pigeon version (flutter/packages#4388)
2023-07-06 [email protected] [url_launcher] Remove nested third_party safari checker (flutter/packages#4330)
2023-07-06 [email protected] [ci] Add partial LUCI Android platform tests (flutter/packages#4381)
2023-07-06 [email protected] [ci] Switch `master` Linux custom package tests to LUCI (flutter/packages#4386)
2023-07-06 [email protected] [go_router] Exposes package-level privates (flutter/packages#4380)
2023-07-06 [email protected] [file_selector] Update to 1.0 (flutter/packages#4362)
2023-07-06 [email protected] Roll Flutter from 35085c3 to bc49cd1 (14 revisions) (flutter/packages#4387)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App needs tests p: local_auth platform-windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants