Skip to content

[camera_android_camerax] Remove duplicated 'report' in README.md #7708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

EchoEllet
Copy link
Contributor

Remove the duplicated report word in README.md of camera_android_camerax package.

List which issues are fixed by this PR. You must list at least one issue.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@EchoEllet EchoEllet requested a review from camsim99 as a code owner September 26, 2024 11:31
Copy link

google-cla bot commented Sep 26, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@EchoEllet EchoEllet changed the title [camera_android_camerax]: remove duplicated 'report' in README.md [camera_android_camerax] Remove duplicated 'report' in README.md Sep 26, 2024
@EchoEllet
Copy link
Contributor Author

I didn't update the pubspec.yaml and CHANGELOG.md since this is a very minor change that doesn't affect the functionality of the package, CHANGELOG.md is usually for the end user or the developer who uses the package. Having all kinds of changes there will be more like git logs in a change log file. Let me know if I should update those two files.

Copy link
Contributor

@camsim99 camsim99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

I will override the check for a CHANGELOG entry since this is just a typo.

@camsim99 camsim99 added override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes autosubmit Merge PR when tree becomes green via auto submit App labels Oct 1, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 1, 2024
Copy link
Contributor

auto-submit bot commented Oct 1, 2024

auto label is removed for flutter/packages/7708, due to This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.

  • Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@camsim99 camsim99 requested a review from gmackall October 1, 2024 14:05
@gmackall gmackall added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 11, 2024
@auto-submit auto-submit bot merged commit 869a3de into flutter:main Oct 11, 2024
76 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 14, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 14, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 14, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 14, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Oct 14, 2024
flutter/packages@67401e1...1e670f2

2024-10-14 [email protected] [image_picker] Update for non-nullable generics in Pigeon (flutter/packages#7775)
2024-10-14 [email protected] [camera_android] Convert calls from native to dart side to Pigeon. (flutter/packages#7857)
2024-10-14 [email protected] [google_maps_flutter_android] Update JSON code to Pigeon for `BitmapDescriptor`, `Cap`, and `PatternItem` (flutter/packages#7840)
2024-10-13 [email protected] [flutter_markdown] Soft wrapping in blockquotes (flutter/packages#7848)
2024-10-12 [email protected] [google_maps_flutter] Update iOS Pigeon for non-nullable generics (flutter/packages#7792)
2024-10-11 [email protected] [pigeon] Swift implementation for ProxyApis (flutter/packages#6602)
2024-10-11 [email protected] [camera_android_camerax] Remove duplicated 'report' in README.md (flutter/packages#7708)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: camera
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants