[flutter_markdown] Soft wrapping in blockquotes #7848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nate-thegrate
approved these changes
Oct 12, 2024
Yeah, I've noticed the GitHub website is a bit funky, since it notices all line breaks in issue or PR comments, but if you upload a |
|
Ok, it's passing now. I don't know why the version number was bad, I tried to follow the latest changes which just fixed minor stuff. |
I don't fully understand it either, but thanks for fixing it! One small thing to mention—it looks like a |
|
Sorry, that was just some GitHub VS Code garbage! I think it's fixed now. |
|
Awesome! We'll be able to merge once the PR has 2 approvals. |
domesticmouse
approved these changes
Oct 13, 2024
nate-thegrate
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 14, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 14, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 14, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 14, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 14, 2024
flutter/packages@67401e1...1e670f2 2024-10-14 [email protected] [image_picker] Update for non-nullable generics in Pigeon (flutter/packages#7775) 2024-10-14 [email protected] [camera_android] Convert calls from native to dart side to Pigeon. (flutter/packages#7857) 2024-10-14 [email protected] [google_maps_flutter_android] Update JSON code to Pigeon for `BitmapDescriptor`, `Cap`, and `PatternItem` (flutter/packages#7840) 2024-10-13 [email protected] [flutter_markdown] Soft wrapping in blockquotes (flutter/packages#7848) 2024-10-12 [email protected] [google_maps_flutter] Update iOS Pigeon for non-nullable generics (flutter/packages#7792) 2024-10-11 [email protected] [pigeon] Swift implementation for ProxyApis (flutter/packages#6602) 2024-10-11 [email protected] [camera_android_camerax] Remove duplicated 'report' in README.md (flutter/packages#7708) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes
flutter_markdowntreat paragraphs in blockquotes like a normal paragraph with respect to soft wrapping.Currently, line breaks in blockquotes translate directly to line breaks in the output. This happens regardless of the Markdown Specification chosen. Such behavior is different from most Markdown implementations, including the reference ones cited in flutter_markdown (Dart Markdown Live Editor and the Markdown Live Preview).
Example:
Currently renders like:
And this PR fixes it to become:
Note: previewing in this GitHub editor, I get the hard-wrap behavior. However, Dart Markdown Live Editor gives the soft-wrap behavior in all flavors, even when "GitHub Flavored Markdown" is selected. Reading the GFM spec there's an example that to me implies that soft-wrapping is the correct thing in GFM, plus that's what I gather from reading 6.12 and 6.13. However, if for some reason we should hard-wrap in GFM, it should be just a matter of checking the chosen
extensionSetwhen deciding whether to calltrimText(). Seems clear to me hard-wrapping shouldn't ever be the only behavior.Issues: this fixes flutter/flutter#156554
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///). -- nothing to update or add I guessIf you need help, consider asking for advice on the #hackers-new channel on Discord.