[camera_android] Convert calls from native to dart side to Pigeon. #7857
Conversation
yaakovschectman
requested review from
stuartmorgan-g,
reidbaker,
gmackall,
a team and
hellohuanlin
...ges/camera/camera_android/android/src/main/java/io/flutter/plugins/camera/DartMessenger.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| handler.post(() -> deviceChannel.invokeMethod(eventType.method, args)); | ||
| String errorMessage = (description == null) ? "" : description; |
There was a problem hiding this comment.
Minimal null check as description is Nullable.
There was a problem hiding this comment.
Could you put a TODO (with an issue link) on this line to fix description being nullable and update any failing call sites? Actually fixing it is out of scope of this PR, but the fact that we need this line is a significant problem since there's no other content in the message, so if we ever actually do this, the plugin client will get absolutely no actionable information.
| } | ||
|
|
||
| handler.post(() -> deviceChannel.invokeMethod(eventType.method, args)); | ||
| String errorMessage = (description == null) ? "" : description; |
There was a problem hiding this comment.
Could you put a TODO (with an issue link) on this line to fix description being nullable and update any failing call sites? Actually fixing it is out of scope of this PR, but the fact that we need this line is a significant problem since there's no other content in the message, so if we ever actually do this, the plugin client will get absolutely no actionable information.
|
|
||
| import androidx.annotation.NonNull; | ||
|
|
||
| /** A convenience class for results of a Pigeon Flutter API method call that perform no action. */ |
There was a problem hiding this comment.
Please add this line to the comment as well; it's true of this plugin as well.
flutter/packages@67401e1...1e670f2 2024-10-14 [email protected] [image_picker] Update for non-nullable generics in Pigeon (flutter/packages#7775) 2024-10-14 [email protected] [camera_android] Convert calls from native to dart side to Pigeon. (flutter/packages#7857) 2024-10-14 [email protected] [google_maps_flutter_android] Update JSON code to Pigeon for `BitmapDescriptor`, `Cap`, and `PatternItem` (flutter/packages#7840) 2024-10-13 [email protected] [flutter_markdown] Soft wrapping in blockquotes (flutter/packages#7848) 2024-10-12 [email protected] [google_maps_flutter] Update iOS Pigeon for non-nullable generics (flutter/packages#7792) 2024-10-11 [email protected] [pigeon] Swift implementation for ProxyApis (flutter/packages#6602) 2024-10-11 [email protected] [camera_android_camerax] Remove duplicated 'report' in README.md (flutter/packages#7708) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Part of the effort to transition to typesafe implementations for platform calls. Android analog to #6568
Part of flutter/flutter#117905
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.