[animations] Remove `.flutter-plugins` reference from example app #8002

camsim99 · 2024-11-01T22:21:13Z

Removes .flutter-plugins reference from example by (1) deleting the packages/animations/example/android directory, (2) running (in the packages/animations directory)

flutter create example --platforms android -a kotlin --org "dev.flutter.packages.animations"

and then (3) manually made the following changes:

Added back packages/animations/example/android/.pluginToolsConfig.yaml (removed by command)
Updated the Gradle version from 8.7 to 8.3 (downgraded by command)
Deleted example/analysis_options.yaml (added by command)
Deleted example/test/ (added by command)
Added back artifact hub
Removed template TODOs
Bumped Kotlin Gradle version to 1.9.0
Bumped AGP version from 8.1.0 to 8.5.1.

Part of flutter/flutter#157660.

Pre-launch Checklist

camsim99 · 2024-11-05T18:14:47Z

I believe this should be changelog/version exempt.

matanlurey

Looks good and hopefully mechanically easy! Thank you!

stuartmorgan-g · 2024-11-05T18:56:19Z

packages/animations/example/android/app/build.gradle

        }
    }
-    namespace 'dev.flutter.packages.animations.example'
-    lint {
-        disable 'InvalidPackage'


Interesting, we don't need this any more? It was added relatively recently (#3574)

Oh I didn't catch this when I was adding back removed lines. I'll add it back.

I didn't see any failed Android lint tests though 🤷🏻 Maybe @reidbaker remembers why we needed this.

I dont remember reading the definition also didnt jog my memory.

Let's try removing it then :)

.../example/android/app/src/main/kotlin/dev/flutter/packages/animations/example/MainActivity.kt

packages/animations/example/android/app/build.gradle

stuartmorgan-g · 2024-11-05T19:01:15Z

packages/animations/example/android/build.gradle

-        if (System.getenv().containsKey(artifactRepoKey)) {
-            println "Using artifact hub"
-            maven { url System.getenv(artifactRepoKey) }
-        }


You'll need to add the new artifact hub code; see https://github.com/flutter/packages/pull/7822/files for an example.

flutter-dashboard · 2024-11-05T19:09:40Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

stuartmorgan-g · 2024-11-05T19:17:23Z

test-exempt: code refactor with no semantic change

packages/animations/example/android/settings.gradle

…pace forms

camsim99 · 2024-11-07T22:50:31Z

Ended up having to modify the gradle-check command to accept namespace = 'namespace.name.here'/namespace = "namespace.name.here" as well as namespace 'namespace.name.here'.

script/tool/lib/src/gradle_check_command.dart

reidbaker

I think one regex is better than 2 for this situation.

stuartmorgan-g

LGTM

stuartmorgan-g · 2024-11-08T18:41:34Z

packages/animations/example/android/settings.gradle

-  }
+plugins {
+    id "dev.flutter.flutter-plugin-loader" version "1.0.0"
+    id "com.android.application" version "8.1.0" apply false


This is the AGP version, right? The app was 8.5.1 before, so we should probably keep that.

Good catch!!

…le app (flutter/packages#8002)

flutter/packages@72356fd...26e123a 2024-11-13 [email protected] [camera_windows] Set device media type for video preview explicitly (flutter/packages#7447) 2024-11-13 [email protected] [go_router] Add support for relative routes (flutter/packages#6825) 2024-11-13 [email protected] [vector_graphics_compiler] fix a renamed method parameter lint (flutter/packages#8070) 2024-11-12 [email protected] [in_app_purchase] Add expiration date to Transaction (flutter/packages#8030) 2024-11-12 [email protected] [various] Clean up contributing guides (flutter/packages#8032) 2024-11-12 [email protected] [ci] Remove web renderer option from tools. (flutter/packages#8055) 2024-11-12 [email protected] [url_launcher] Update Pigeon version for Linux (flutter/packages#8065) 2024-11-12 [email protected] [go_router] Add support for preloading branches of StatefulShellRoute (revised solution) (flutter/packages#6467) 2024-11-12 [email protected] [pigeon] Make Linux type declarations public (flutter/packages#8040) 2024-11-11 [email protected] Roll Flutter from 73546b3 to c8510f2 (30 revisions) (flutter/packages#8042) 2024-11-11 [email protected] Use dependabot multi-directory configuration for Android package updates (flutter/packages#8048) 2024-11-11 [email protected] [tools] Run `pub get` before `format` (flutter/packages#8052) 2024-11-11 [email protected] [file_selector] Fix Linux cancel regression (flutter/packages#8051) 2024-11-09 [email protected] [shared_preferences] Fix confusing language in README (flutter/packages#8049) 2024-11-08 [email protected] Use dependabot multi-directory configuration for Android example gradle updates (flutter/packages#8036) 2024-11-08 [email protected] [animations] Remove `.flutter-plugins` reference from example app (flutter/packages#8002) 2024-11-08 [email protected] Group dependabot github-action update PRs, delete dead docker updates (flutter/packages#8044) 2024-11-08 [email protected] [vector_graphics_compiler] fix-null-exception (flutter/packages#8006) 2024-11-08 [email protected] [tools] Format Dart per-package (flutter/packages#8043) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

camsim99 added 2 commits November 1, 2024 15:14

first attempt

ac456d2

Undo changes I did not like

2da3529

github-actions bot added p: animations platform-android labels Nov 1, 2024

camsim99 mentioned this pull request Nov 1, 2024

Update settings.gradle for example apps to remove .flutter-plugins flutter/flutter#157660

Closed

camsim99 added 2 commits November 1, 2024 15:38

remove spaces

3a52373

Merge remote-tracking branch 'upstream/main' into fp_dep

de13176

camsim99 added 2 commits November 5, 2024 10:29

Try modifying kotlin options

eb88da3

remove duplicate kotlinOptions block

0a59b04

camsim99 marked this pull request as ready for review November 5, 2024 18:45

camsim99 requested a review from goderbauer as a code owner November 5, 2024 18:45

camsim99 requested review from stuartmorgan-g and matanlurey November 5, 2024 18:45

matanlurey approved these changes Nov 5, 2024

View reviewed changes

stuartmorgan-g requested changes Nov 5, 2024

View reviewed changes

camsim99 added 2 commits November 6, 2024 14:36

Address review

edde394

Format and add back removed block

7b75557

jesswrd self-requested a review November 7, 2024 17:56

jesswrd reviewed Nov 7, 2024

View reviewed changes

packages/animations/example/android/settings.gradle Outdated Show resolved Hide resolved

Bump kotlin version and update gradle-check to accept different names…

78b5fd0

…pace forms

camsim99 requested a review from stuartmorgan-g November 7, 2024 22:50

camsim99 added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Nov 7, 2024

stuartmorgan-g reviewed Nov 8, 2024

View reviewed changes

script/tool/lib/src/gradle_check_command.dart Outdated Show resolved Hide resolved

reidbaker approved these changes Nov 8, 2024

View reviewed changes

Remove second regex

5677d9e

Add comment with examples

557c32e

camsim99 added autosubmit Merge PR when tree becomes green via auto submit App and removed autosubmit Merge PR when tree becomes green via auto submit App labels Nov 8, 2024

camsim99 requested a review from stuartmorgan-g November 8, 2024 18:27

stuartmorgan-g approved these changes Nov 8, 2024

View reviewed changes

Bump back up AGP version

f76db65

camsim99 added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 8, 2024

auto-submit bot merged commit a3ea39d into flutter:main Nov 8, 2024
76 checks passed

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 8, 2024

engine-flutter-autoroll mentioned this pull request Nov 11, 2024

Roll Packages from bb5a25815cae to d681e4e404e8 (15 revisions) flutter/flutter#158468

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 11, 2024

a3ea39db0 [animations] Remove .flutter-plugins reference from examp…

cde34bb

…le app (flutter/packages#8002)

engine-flutter-autoroll mentioned this pull request Nov 12, 2024

Roll Packages from 72356fda4684 to 5e90ce258e33 (11 revisions) flutter/flutter#158509

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2024

a3ea39db0 [animations] Remove .flutter-plugins reference from examp…

f12d15c

…le app (flutter/packages#8002)

engine-flutter-autoroll mentioned this pull request Nov 12, 2024

Roll Packages from 72356fda4684 to 9c294efb9eb4 (12 revisions) flutter/flutter#158514

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2024

a3ea39db0 [animations] Remove .flutter-plugins reference from examp…

13514e4

…le app (flutter/packages#8002)

engine-flutter-autoroll mentioned this pull request Nov 13, 2024

Roll Packages from 72356fda4684 to 67d8b50c1796 (18 revisions) flutter/flutter#158586

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 13, 2024

a3ea39db0 [animations] Remove .flutter-plugins reference from examp…

bd8595a

…le app (flutter/packages#8002)

engine-flutter-autoroll mentioned this pull request Nov 13, 2024

Roll Packages from 72356fda4684 to 26e123a6ce03 (19 revisions) flutter/flutter#158626

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 13, 2024

a3ea39db0 [animations] Remove .flutter-plugins reference from examp…

1479fed

…le app (flutter/packages#8002)

[animations] Remove .flutter-plugins reference from example app #8002

[animations] Remove .flutter-plugins reference from example app #8002

Uh oh!

Conversation

camsim99 commented Nov 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

camsim99 commented Nov 5, 2024

Uh oh!

matanlurey left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

flutter-dashboard bot commented Nov 5, 2024

Uh oh!

stuartmorgan-g commented Nov 5, 2024

Uh oh!

Uh oh!

camsim99 commented Nov 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

reidbaker left a comment

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

[animations] Remove `.flutter-plugins` reference from example app #8002

[animations] Remove `.flutter-plugins` reference from example app #8002

camsim99 commented Nov 1, 2024 •

edited

Loading

camsim99 commented Nov 7, 2024 •

edited

Loading