[various] Clean up contributing guides #8032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several packages had documentation about how to use Pigeon or Mockito generation; this made sense when those were rare, but they are both now extremely common in our packages. Instead, flutter/flutter#158326 adds this information to the general documentation for contribuing to flutter/packages, so it no longer needs to be in (a random subset of) specific packages. This also removes Contributing sections from several READMEs, as READMEs should be client-focused rather than developer-focused, and puts content in CONTRIBUTING.md where needed.
stuartmorgan-g
requested review from
cbracken,
hellohuanlin,
LouiseHsu,
bparrishMines,
camsim99,
matanlurey,
gmackall and
ditman
as code owners
github-actions
bot
added
p: camera
p: in_app_purchase
platform-android
platform-ios
platform-macos
platform-web
p: webview_flutter
p: video_player
p: interactive_media_ads
cbracken
approved these changes
Nov 7, 2024
matanlurey
approved these changes
Nov 7, 2024
ditman
approved these changes
Nov 7, 2024
Comment on lines
+11
to
+13
| ```bash | ||
| $ flutter test --platform chrome | ||
| ``` |
LouiseHsu
approved these changes
Nov 7, 2024
stuartmorgan-g
added
the
autosubmit
|
auto label is removed for flutter/packages/8032, due to - The status or check suite Mac_x64 ios_build_all_packages stable has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
stuartmorgan-g
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 13, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 13, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 13, 2024
flutter/packages@72356fd...26e123a 2024-11-13 [email protected] [camera_windows] Set device media type for video preview explicitly (flutter/packages#7447) 2024-11-13 [email protected] [go_router] Add support for relative routes (flutter/packages#6825) 2024-11-13 [email protected] [vector_graphics_compiler] fix a renamed method parameter lint (flutter/packages#8070) 2024-11-12 [email protected] [in_app_purchase] Add expiration date to Transaction (flutter/packages#8030) 2024-11-12 [email protected] [various] Clean up contributing guides (flutter/packages#8032) 2024-11-12 [email protected] [ci] Remove web renderer option from tools. (flutter/packages#8055) 2024-11-12 [email protected] [url_launcher] Update Pigeon version for Linux (flutter/packages#8065) 2024-11-12 [email protected] [go_router] Add support for preloading branches of StatefulShellRoute (revised solution) (flutter/packages#6467) 2024-11-12 [email protected] [pigeon] Make Linux type declarations public (flutter/packages#8040) 2024-11-11 [email protected] Roll Flutter from 73546b3 to c8510f2 (30 revisions) (flutter/packages#8042) 2024-11-11 [email protected] Use dependabot multi-directory configuration for Android package updates (flutter/packages#8048) 2024-11-11 [email protected] [tools] Run `pub get` before `format` (flutter/packages#8052) 2024-11-11 [email protected] [file_selector] Fix Linux cancel regression (flutter/packages#8051) 2024-11-09 [email protected] [shared_preferences] Fix confusing language in README (flutter/packages#8049) 2024-11-08 [email protected] Use dependabot multi-directory configuration for Android example gradle updates (flutter/packages#8036) 2024-11-08 [email protected] [animations] Remove `.flutter-plugins` reference from example app (flutter/packages#8002) 2024-11-08 [email protected] Group dependabot github-action update PRs, delete dead docker updates (flutter/packages#8044) 2024-11-08 [email protected] [vector_graphics_compiler] fix-null-exception (flutter/packages#8006) 2024-11-08 [email protected] [tools] Format Dart per-package (flutter/packages#8043) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several packages had documentation about how to use Pigeon or Mockito generation; this made sense when those were rare, but they are both now extremely common in our packages. Instead,
flutter/flutter#158326 adds this information to the general documentation for contribuing to flutter/packages, so it no longer needs to be in (a random subset of) specific packages.
This also removes Contributing sections from several READMEs, as READMEs should be client-focused rather than developer-focused, and puts content in CONTRIBUTING.md where needed.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).