[shared_preferences] Fix confusing language in README #8049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One use of "class" instead of "plugin" to refer to the `SharedPreferences` class specifically slipped through review. This updates it to make it clear that it's talking about a specific class, not the plugin.
tarrinneal
approved these changes
Nov 9, 2024
stuartmorgan-g
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 11, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 12, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 12, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 13, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 13, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 13, 2024
flutter/packages@72356fd...26e123a 2024-11-13 [email protected] [camera_windows] Set device media type for video preview explicitly (flutter/packages#7447) 2024-11-13 [email protected] [go_router] Add support for relative routes (flutter/packages#6825) 2024-11-13 [email protected] [vector_graphics_compiler] fix a renamed method parameter lint (flutter/packages#8070) 2024-11-12 [email protected] [in_app_purchase] Add expiration date to Transaction (flutter/packages#8030) 2024-11-12 [email protected] [various] Clean up contributing guides (flutter/packages#8032) 2024-11-12 [email protected] [ci] Remove web renderer option from tools. (flutter/packages#8055) 2024-11-12 [email protected] [url_launcher] Update Pigeon version for Linux (flutter/packages#8065) 2024-11-12 [email protected] [go_router] Add support for preloading branches of StatefulShellRoute (revised solution) (flutter/packages#6467) 2024-11-12 [email protected] [pigeon] Make Linux type declarations public (flutter/packages#8040) 2024-11-11 [email protected] Roll Flutter from 73546b3 to c8510f2 (30 revisions) (flutter/packages#8042) 2024-11-11 [email protected] Use dependabot multi-directory configuration for Android package updates (flutter/packages#8048) 2024-11-11 [email protected] [tools] Run `pub get` before `format` (flutter/packages#8052) 2024-11-11 [email protected] [file_selector] Fix Linux cancel regression (flutter/packages#8051) 2024-11-09 [email protected] [shared_preferences] Fix confusing language in README (flutter/packages#8049) 2024-11-08 [email protected] Use dependabot multi-directory configuration for Android example gradle updates (flutter/packages#8036) 2024-11-08 [email protected] [animations] Remove `.flutter-plugins` reference from example app (flutter/packages#8002) 2024-11-08 [email protected] Group dependabot github-action update PRs, delete dead docker updates (flutter/packages#8044) 2024-11-08 [email protected] [vector_graphics_compiler] fix-null-exception (flutter/packages#8006) 2024-11-08 [email protected] [tools] Format Dart per-package (flutter/packages#8043) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One use of "class" instead of "plugin" to refer to the
SharedPreferencesclass specifically slipped through review. This updates it to make it clear that it's talking about a specific class, not the plugin.Also updates the
setPrefix:doc comment to clarify that it only applies to that class, now that the addition of other classes to the API surface has made that ambiguous.Fixes flutter/flutter#158404
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).