Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[webview_flutter] Add new entrypoint that uses hybrid composition on Android #3067

Merged
merged 19 commits into from
Sep 30, 2020
Merged

[webview_flutter] Add new entrypoint that uses hybrid composition on Android #3067

merged 19 commits into from
Sep 30, 2020

Conversation

bparrishMines
Copy link
Contributor

@bparrishMines bparrishMines commented Sep 21, 2020 •
edited
Loading

Related Issues

Fixes flutter/flutter#61133

Tests on stable will fail until hybrid views support moves to stable.

To try early, add the dependency to your pubspec.yaml and switch to Flutter's master branch.

dependencies:
  webview_flutter:
    git:
      url: [email protected]:bparrishMines/plugins.git
      path: packages/webview_flutter
      ref: webview_entrypoint

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@bparrishMines bparrishMines mentioned this pull request Sep 21, 2020
Merged
13 tasks
@blasten
Copy link

blasten commented Sep 21, 2020

SDK bump: flutter: ">=1.22.0" and version is 0.4.0.

@amirh are there any concerns with bumping the Flutter SDK constraint in pubspec.yaml?

@tvolkert tvolkert mentioned this pull request Sep 28, 2020
Closed
blasten
blasten reviewed Sep 29, 2020
View reviewed changes
packages/webview_flutter/pubspec.yaml Outdated
homepage: https://github.com/flutter/plugins/tree/master/packages/webview_flutter

environment:
sdk: ">=2.7.0 <3.0.0"
flutter: ">=1.12.13+hotfix.5"
flutter: ">=1.22.0"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this is >=1.22.0-10.0.pre <2.0.0 in Maps.

blasten
blasten approved these changes Sep 29, 2020
View reviewed changes
Copy link

@blasten blasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

amirh
amirh approved these changes Sep 30, 2020
View reviewed changes
Copy link
Contributor

@amirh amirh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bparrishMines bparrishMines merged commit 6d8b156 into flutter:master Sep 30, 2020
@bparrishMines bparrishMines deleted the webview_entrypoint branch September 30, 2020 22:02
@darshankawar darshankawar mentioned this pull request Oct 5, 2020
Closed
yasargil added a commit to yasargil/plugins that referenced this pull request Oct 8, 2020
@yasargil
Merge branch 'master' into gmain
5c53cee 
* master:
  [in_app_purchase] Android Code Inspection and Clean up (flutter#3120)
  Android Code Inspection and Clean up (flutter#3117)
  [in_app_purchase] Fix finishing purchases upon payment cancellation (flutter#3106)
  [google_maps_flutter_web] Fix convert.dart issues (flutter#3093)
  [multiple] Opt-out tests of null-safety (flutter#3113)
  [webview_flutter] add public documentation. (flutter#3114)
  in_app_purchase: started supported null as a parameter for the sandbox arguement (flutter#3110)
  [connectivity] Android Code Inspection and Clean up (flutter#3051)
  [android_intent] Android Code Inspection and Clean up (flutter#3043)
  Remove `io.flutter.embedded_views_preview` from README
  [google_maps_flutter] Fix headline in the readme (flutter#3100)
  [webview_flutter] Add new entrypoint that uses hybrid composition on Android (flutter#3067)
  [google_maps_flutter] Out of developers preview, bump to 1.0.0 (flutter#3091)
  [url_launcher_web] Move third_party under src. (flutter#3080)
  [plugin_platform_interface] Fix homepage in pubspec.yaml (flutter#3088)
  [connectivity_for_web] Fix homepage in pubspec.yaml (flutter#3089)
  [in_app_purchase] Update typo in example main.dart (flutter#3073)
jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020
@bparrishMines @jorgefspereira
[webview_flutter] Add new entrypoint that uses hybrid composition on …
d4fbc84 
…Android (flutter#3067)
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
@bparrishMines
[webview_flutter] Add new entrypoint that uses hybrid composition on …
3cdb50a 
…Android (flutter#3067)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amirh amirh amirh approved these changes

@blasten blasten blasten approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[webview_flutter] Add new entrypoint that uses hybrid composition on Android
4 participants
@bparrishMines @blasten @amirh @googlebot