Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[in_app_purchase] Update typo in example main.dart #3073

Merged
merged 3 commits into from
Sep 29, 2020
Merged

[in_app_purchase] Update typo in example main.dart #3073

merged 3 commits into from
Sep 29, 2020

Conversation

LewisHobden
Copy link
Contributor

@LewisHobden LewisHobden commented Sep 23, 2020 •
edited
Loading

Documentation typo.

Description

Fixed a typo in an inline comment.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@LewisHobden
Update main.dart
843097e 
Documentation typo.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@LewisHobden LewisHobden changed the title Update typo in in_app_purchase main.dart [in_app_purchase] Update typo in example main.dart Sep 23, 2020
@LewisHobden
Copy link
Contributor Author

@googlebot I signed it!

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@LewisHobden LewisHobden marked this pull request as ready for review September 24, 2020 08:22
LHLL
LHLL approved these changes Sep 24, 2020
View reviewed changes
Copy link
Contributor

@LHLL LHLL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! LGTM.

@LHLL
Copy link
Contributor

LHLL commented Sep 24, 2020

Sorry, can you also update CHANGELOG.md and pubspec.yaml?

@LewisHobden
Copy link
Contributor Author

I have committed changes to CHANGELOG + pubspec.yaml!

@LHLL
Copy link
Contributor

LHLL commented Sep 29, 2020

Thanks a lot!

@LHLL LHLL merged commit d82940f into flutter:master Sep 29, 2020
yasargil added a commit to yasargil/plugins that referenced this pull request Oct 8, 2020
@yasargil
Merge branch 'master' into gmain
5c53cee 
* master:
  [in_app_purchase] Android Code Inspection and Clean up (flutter#3120)
  Android Code Inspection and Clean up (flutter#3117)
  [in_app_purchase] Fix finishing purchases upon payment cancellation (flutter#3106)
  [google_maps_flutter_web] Fix convert.dart issues (flutter#3093)
  [multiple] Opt-out tests of null-safety (flutter#3113)
  [webview_flutter] add public documentation. (flutter#3114)
  in_app_purchase: started supported null as a parameter for the sandbox arguement (flutter#3110)
  [connectivity] Android Code Inspection and Clean up (flutter#3051)
  [android_intent] Android Code Inspection and Clean up (flutter#3043)
  Remove `io.flutter.embedded_views_preview` from README
  [google_maps_flutter] Fix headline in the readme (flutter#3100)
  [webview_flutter] Add new entrypoint that uses hybrid composition on Android (flutter#3067)
  [google_maps_flutter] Out of developers preview, bump to 1.0.0 (flutter#3091)
  [url_launcher_web] Move third_party under src. (flutter#3080)
  [plugin_platform_interface] Fix homepage in pubspec.yaml (flutter#3088)
  [connectivity_for_web] Fix homepage in pubspec.yaml (flutter#3089)
  [in_app_purchase] Update typo in example main.dart (flutter#3073)
jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020
@LewisHobden @jorgefspereira
[in_app_purchase] Update typo in example main.dart (flutter#3073)
d5a19f0 
* Update main.dart

Documentation typo.

* Update CHANGELOG.md

* Update pubspec.yaml
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
@LewisHobden
[in_app_purchase] Update typo in example main.dart (flutter#3073)
97925b6 
* Update main.dart

Documentation typo.

* Update CHANGELOG.md

* Update pubspec.yaml
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@LHLL LHLL LHLL approved these changes

@cyanglaz cyanglaz Awaiting requested review from cyanglaz

@mklim mklim Awaiting requested review from mklim

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LewisHobden @googlebot @LHLL