[in_app_purchase] Fix finishing purchases upon payment dialog cancel… #3106

dennis-tra · 2020-10-02T10:14:13Z

Description

This PR fixes finishing purchases upon payment dialog cancellation on iOS.

When the user cancels the payment dialog there is no transactionIdentifier which means the transaction cannot be finished in the current implementation and therefore not initiated again.

Duplicate of:

[in_app_purchase] Fix AppStore cancel payment modal #3074

Related Issues

[in_app_purchase] Getting error while completing error purchases on iOS 14 flutter#66253
[in_app_purchase] Cannot start a new purchase after cancelling on iOS 14 flutter#66886

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
No, this is not a breaking change.

googlebot · 2020-10-02T10:14:18Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

dennis-tra · 2020-10-02T10:17:12Z

@googlebot I signed it!

googlebot · 2020-10-02T10:17:16Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

LHLL

Thanks for fixing this!

LHLL · 2020-10-02T16:14:55Z

packages/in_app_purchase/ios/Classes/InAppPurchasePlugin.m


  NSArray<SKPaymentTransaction *> *pendingTransactions =
      [self.paymentQueueHandler getUnfinishedTransactions];

  for (SKPaymentTransaction *transaction in pendingTransactions) {
-    if ([transaction.transactionIdentifier isEqualToString:transactionIdentifier]) {
+    // If the user cancels the purchase dialog we won't have a transactionIdentifier. So if it is


I think these two words break the line. Same below.

I reformatted the comment

LHLL · 2020-10-02T16:16:05Z

packages/in_app_purchase/lib/src/store_kit_wrappers/sk_payment_queue_wrapper.dart

@@ -103,9 +103,11 @@ class SKPaymentQueueWrapper {
  /// finishTransaction:]`](https://developer.apple.com/documentation/storekit/skpaymentqueue/1506003-finishtransaction?language=objc).
  Future<void> finishTransaction(
      SKPaymentTransactionWrapper transaction) async {
+    Map requestMap = transaction.toFinishMap();


Prefer lightweight generic. Consider adding a type for the Map. For example: Map<String, String>

LHLL

LGTM! Thanks.

cyanglaz

Looks like the version needs to be updated from pubspec.yaml

luisdhm · 2020-10-06T18:36:44Z

Still getting an error after calling completePurchase method in version 0.3.4+11.
PlatformException(storekit_invalid_argument, Argument type of finishTransaction is not a Dictionary, null, null)

EDIT: Worked with latest version 0.3.4+12

fbardecio · 2020-10-06T20:21:20Z

Hi! I'm experiencing the same error PlatformException(storekit_invalid_argument, Argument type of finishTransaction is not a Dictionary, null, null)

EDIT: My bad, it is working after switching to a new sandbox account (IDK if it has something to do but just in case) and also running flutter clean! Thanks for the fix!

DangKhoi1997 · 2020-10-07T09:11:45Z

Updated to version 0.3.4+12 but it still not pop up purchase dialog :(. Anyone has same error ??

LHLL · 2020-10-07T18:42:27Z

Updated to version 0.3.4+12 but it still not pop up purchase dialog :(. Anyone has same error ??

@DangKhoi1997 I think dialog not showing up is a different issue and not related to this PR. Apple Pay UI/dialog is not showing up is related to not finishing transactions. Can you try something similar to following code to see if your problem is solved:

class PurchaseService{
    final _connection = InAppPurchaseConnection();

    const PurchaseService(){
          _connection.purchaseUpdatedStream.listen((detail) {
               ...
              // Verify the receipt for succeeded transactions and handle the error for the failed
              // transaction here.
              _connection.completePurchase(detail);
          });    
    }
}

* master: [in_app_purchase] Android Code Inspection and Clean up (flutter#3120) Android Code Inspection and Clean up (flutter#3117) [in_app_purchase] Fix finishing purchases upon payment cancellation (flutter#3106) [google_maps_flutter_web] Fix convert.dart issues (flutter#3093) [multiple] Opt-out tests of null-safety (flutter#3113) [webview_flutter] add public documentation. (flutter#3114) in_app_purchase: started supported null as a parameter for the sandbox arguement (flutter#3110) [connectivity] Android Code Inspection and Clean up (flutter#3051) [android_intent] Android Code Inspection and Clean up (flutter#3043) Remove `io.flutter.embedded_views_preview` from README [google_maps_flutter] Fix headline in the readme (flutter#3100) [webview_flutter] Add new entrypoint that uses hybrid composition on Android (flutter#3067) [google_maps_flutter] Out of developers preview, bump to 1.0.0 (flutter#3091) [url_launcher_web] Move third_party under src. (flutter#3080) [plugin_platform_interface] Fix homepage in pubspec.yaml (flutter#3088) [connectivity_for_web] Fix homepage in pubspec.yaml (flutter#3089) [in_app_purchase] Update typo in example main.dart (flutter#3073)

daoc13 · 2020-10-08T16:20:22Z

Updated to latest version 0.3.4+12 but we are still not able to buy again whenever we cancel the purchase dialogue. The button works fine if we complete the purchase flow and I am able to buy many time if the purchase flow ends correct, but whenever I cancel and try to tap again the button it won’t open the purchase dialogue. Do we need to add any additional code to our implementation?

…lutter#3106)

hai199580 · 2020-11-24T10:03:59Z

Updated to latest version 0.3.4+12 but we are still not able to buy again whenever we cancel the purchase dialogue. The button works fine if we complete the purchase flow and I am able to buy many time if the purchase flow ends correct, but whenever I cancel and try to tap again the button it won’t open the purchase dialogue. Do we need to add any additional code to our implementation?

@daoc13 do you find any solution for this issue :((

daoc13 · 2020-11-25T03:26:00Z

Updated to latest version 0.3.4+12 but we are still not able to buy again whenever we cancel the purchase dialogue. The button works fine if we complete the purchase flow and I am able to buy many time if the purchase flow ends correct, but whenever I cancel and try to tap again the button it won’t open the purchase dialogue. Do we need to add any additional code to our implementation?

@daoc13 do you find any solution for this issue :((

@hai199580 I did not find a solution for this issue. I recommend you to use Revenue Cat, we implemented it in 4 hours and it works fine. I will keep using Revenue Cat until this issue is solved. Hope it helps!

dennis-tra requested review from cyanglaz, LHLL and mklim as code owners October 2, 2020 10:14

googlebot added the cla: no label Oct 2, 2020

dennis-tra mentioned this pull request Oct 2, 2020

[in_app_purchase] Fix AppStore cancel payment modal #3074

Closed

googlebot added cla: yes and removed cla: no labels Oct 2, 2020

dennis-tra changed the title ~~[in_app_purchase] Fixe finishing purchases upon payment dialog cancel…~~ [in_app_purchase] Fix finishing purchases upon payment dialog cancel… Oct 2, 2020

dennis-tra force-pushed the in_app_purchase/cancel_modal branch from 04b5870 to a8a1909 Compare October 2, 2020 10:23

This was referenced Oct 2, 2020

[in_app_purchase] Cannot start a new purchase after cancelling on iOS 14 flutter/flutter#66886

Closed

[in_app_purchase] Getting error while completing error purchases on iOS 14 flutter/flutter#66253

Closed

dennis-tra force-pushed the in_app_purchase/cancel_modal branch 5 times, most recently from 285a35c to 51e8c04 Compare October 2, 2020 10:44

LHLL reviewed Oct 2, 2020

View reviewed changes

dennis-tra force-pushed the in_app_purchase/cancel_modal branch from 51e8c04 to a4ae198 Compare October 4, 2020 07:07

LHLL approved these changes Oct 5, 2020

View reviewed changes

[in_app_purchase] Fix finishing purchases upon payment cancellation

1d25eee

dennis-tra force-pushed the in_app_purchase/cancel_modal branch from a4ae198 to 1d25eee Compare October 5, 2020 17:16

cyanglaz suggested changes Oct 5, 2020

View reviewed changes

LHLL merged commit 05b1010 into flutter:master Oct 6, 2020

jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020

[in_app_purchase] Fix finishing purchases upon payment cancellation (f…

37f5727

…lutter#3106)

FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020

[in_app_purchase] Fix finishing purchases upon payment cancellation (f…

faf2b0b

…lutter#3106)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[in_app_purchase] Fix finishing purchases upon payment dialog cancel… #3106

[in_app_purchase] Fix finishing purchases upon payment dialog cancel… #3106

dennis-tra commented Oct 2, 2020 •

edited

Loading

googlebot commented Oct 2, 2020

dennis-tra commented Oct 2, 2020

googlebot commented Oct 2, 2020

LHLL left a comment

LHLL Oct 2, 2020

dennis-tra Oct 4, 2020

LHLL Oct 2, 2020

dennis-tra Oct 4, 2020

LHLL left a comment

cyanglaz left a comment

luisdhm commented Oct 6, 2020 •

edited

Loading

fbardecio commented Oct 6, 2020 •

edited

Loading

DangKhoi1997 commented Oct 7, 2020

LHLL commented Oct 7, 2020 •

edited

Loading

daoc13 commented Oct 8, 2020

hai199580 commented Nov 24, 2020

daoc13 commented Nov 25, 2020

[in_app_purchase] Fix finishing purchases upon payment dialog cancel… #3106

[in_app_purchase] Fix finishing purchases upon payment dialog cancel… #3106

Conversation

dennis-tra commented Oct 2, 2020 • edited Loading

Description

Related Issues

Checklist

Breaking Change

googlebot commented Oct 2, 2020

What to do if you already signed the CLA

Individual signers

Corporate signers

dennis-tra commented Oct 2, 2020

googlebot commented Oct 2, 2020

LHLL left a comment

Choose a reason for hiding this comment

LHLL Oct 2, 2020

Choose a reason for hiding this comment

dennis-tra Oct 4, 2020

Choose a reason for hiding this comment

LHLL Oct 2, 2020

Choose a reason for hiding this comment

dennis-tra Oct 4, 2020

Choose a reason for hiding this comment

LHLL left a comment

Choose a reason for hiding this comment

cyanglaz left a comment

Choose a reason for hiding this comment

luisdhm commented Oct 6, 2020 • edited Loading

fbardecio commented Oct 6, 2020 • edited Loading

DangKhoi1997 commented Oct 7, 2020

LHLL commented Oct 7, 2020 • edited Loading

daoc13 commented Oct 8, 2020

hai199580 commented Nov 24, 2020

daoc13 commented Nov 25, 2020

dennis-tra commented Oct 2, 2020 •

edited

Loading

luisdhm commented Oct 6, 2020 •

edited

Loading

fbardecio commented Oct 6, 2020 •

edited

Loading

LHLL commented Oct 7, 2020 •

edited

Loading