You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Vladyslav Ushakov edited this page Dec 3, 2016
·
9 revisions
[Git flow rules] (working-with-git)
Development rules
[Test driven development] (#tdd)
[Review process] (#review-process)
[Code styles] (#code-styles)
TDD
Development process is based on Test Driven Development. This approach means test-first development where you write a test before you write the implementation.
**:exclamation:**For us, it's generally means that no commits are allowed without unit / integration tests covered the new functionality (no excuses about adding them later).
Usual process for adding new feature:
Create navigation map (list) - story decomposition;
Create tests for new functionality;
Run all tests and see if the new tests fail;
Implement the task;
Run tests again and make sure they all passed;
Refactor code until it's perfect.
Review process
Usually when you are working on the task you have a choice to work:
in the separate branch or
clone the repository
And, then, create a pull request in the end to merge changes into the master.
Every pull request firstly must be reviewed inside the team. It must collect at least 3ninja stars in general (usually, 2 stars from the team members and, at least, one star outside the team).