Skip to content
This repository was archived by the owner on Jul 21, 2020. It is now read-only.

Development rules

Jump to bottom
Oleksandr Hliebov edited this page Dec 3, 2016 · 5 revisions

TDD

Development process is based on Test Driven Development. This approach means test-first development where you write a test before you write the implementation.

**:exclamation:**For us, it's generally means that no commits are allowed without unit / integration tests covered the new functionality (no excuses about adding them later).

Usual process for adding new feature:

  1. Create tests for new functionality;
  2. Run all tests and see if the new tests fail;
  3. Implement the task;
  4. Run tests again and make sure they all passed;
  5. Refactor code until it's perfect.

Review process

Usually when you are working on the task you have a choice to work:

  • in the separate branch or
  • clone the repository

And, then, create a pull request in the end to merge changes into the master.

Every pull request firstly must be reviewed inside the team. It must collect at least 3 ninja stars in general (usually, 2 stars from the team members and, at least, one star outside the team).

Code styles

  • [TypeScript] (../code-style:-typescript)
  • [HTML + CSS] (../code-style:-html)

Clone this wiki locally