Option to install a header, but don't include it in master header#234
Closed
chapulina wants to merge 1 commit intoign-cmake2from
Closed
Option to install a header, but don't include it in master header#234chapulina wants to merge 1 commit intoign-cmake2from
chapulina wants to merge 1 commit intoign-cmake2from
Conversation
Signed-off-by: Louise Poubel <louise@openrobotics.org>
This was referenced Apr 14, 2022
scpeters
reviewed
Apr 14, 2022
| # [EXCLUDE_FILES <excluded_headers>] | ||
| # [EXCLUDE_DIRS <dirs>] | ||
| # [GENERATED_HEADERS <headers>] | ||
| # [INSTALL_BUT_DONT_INCLUDE <headers>] |
Member
There was a problem hiding this comment.
this parameter name is confusing to me
an alternative approach is to use EXCLUDE_FILES and then manually install the desired headers, as we don in sdformat:
it could benefit from an easier install helper so it doesn't need to pass ${IGN_INCLUDE_INSTALL_DIR_FULL}/${PROJECT_INCLUDE_DIR} as the destination
ign_install_includes will provide the first half of that path, but you'd still have to pass ${PROJECT_INCLUDE_DIR}
Contributor
Author
There was a problem hiding this comment.
Ahh much better, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Summary
Add an option to
ign_install_all_headersso that a header is installed, but not included in the master header.I need this feature because I introduced a bunch of warnings to everyone who includes
msgs.hhwhen I deprecatedSuppressWarning.hhinTest it
TODO
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸