Use SuppressWarning from ign-utils

[chapulina]

🎉 New feature

• Similar to Use SuppressWarning from ign-utils gz-common#295
• Related to Deprecate utilities in favor of ign-utils gz-cmake#171

Summary

Now that ign-msgs depends on ign-utils, we don't need to duplicate the warning suppression here anymore.

Test it

You shouldn't get any messages while compiling. To see what the warning looks like, revert the changes in Filesystem.hh and you'll get messages like this:

Starting >>> ignition-msgs9                                           
--- stderr: ignition-msgs9                                                                                                                  
In file included from /home/chapulina/dev_focal/ws_garden/src/ign-msgs/include/ignition/msgs/Filesystem.hh:25,                                               from /home/chapulina/dev_focal/ws_garden/src/ign-msgs/src/Filesystem.cc:59:
/home/chapulina/dev_focal/ws_garden/src/ign-msgs/include/ignition/msgs/SuppressWarning.hh:23:72: note: #pragma message: ign-msgs SuppressWar
ning is deprecated, use ign-utils                                     
   23 | #pragma message("ign-msgs SuppressWarning is deprecated, use ign-utils")
      |                                                                        ^                                           
In file included from /home/chapulina/dev_focal/ws_garden/src/ign-msgs/include/ignition/msgs/Filesystem.hh:25,
                 from /home/chapulina/dev_focal/ws_garden/src/ign-msgs/src/Factory.cc:40:
/home/chapulina/dev_focal/ws_garden/src/ign-msgs/include/ignition/msgs/SuppressWarning.hh:23:72: note: #pragma message: ign-msgs SuppressWarning is deprecated, use ign-utils
   23 | #pragma message("ign-msgs SuppressWarning is deprecated, use ign-utils")
      |                                                                        ^
---                    
Finished <<< ignition-msgs9 [28.8s]  

Checklist

• Signed all commits for DCO
• Added tests
• Added example and/or tutorial
• Updated documentation (as needed)
• Updated migration guide (as needed)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

[codecov]

Codecov Report

Merging #243 (576cfa9) into main (64dc7b6) will decrease coverage by 69.55%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main     #243       +/-   ##
===========================================
- Coverage   85.46%   15.90%   -69.56%     
===========================================
  Files           9      380      +371     
  Lines         956    71119    +70163     
===========================================
+ Hits          817    11312    +10495     
- Misses        139    59807    +59668     

Impacted Files	Coverage Δ
src/Utility.cc
src/Factory.cc
src/generator_main.cc
src/Filesystem.cc
src/Generator.cc
src/ign.cc
include/ignition/msgs/PointCloudPackedUtils.hh
...lude/ignition/msgs/detail/PointCloudPackedUtils.hh
include/ignition/msgs/Factory.hh
include/ignition/msgs/particle_emitter.pb.h	0.82% <0.00%> (ø)
... and 379 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64dc7b6...576cfa9. Read the comment docs.

[chapulina]

Ahh this added a bunch of warnings downstream because SuppressWarnings.hh is included by msgs.hh. Looking into it

[mjcarroll]

Oh, we should exclude it from msgs.hh for sure

[chapulina]

See

• Option to install a header, but don't include it in master header gz-cmake#234
• Remove SuppressWarning from msgs.hh to fix warnings #245