Remove SuppressWarning from msgs.hh to fix warnings#245
Merged
Conversation
Signed-off-by: Louise Poubel <louise@openrobotics.org>
chapulina
added
the
needs upstream release
8 tasks
Codecov Report
@@ Coverage Diff @@
## main #245 +/- ##
=======================================
Coverage 15.91% 15.91%
=======================================
Files 382 382
Lines 71391 71391
=======================================
Hits 11361 11361
Misses 60030 60030 Continue to review full report at Codecov.
|
scpeters
reviewed
Apr 14, 2022
Signed-off-by: Louise Poubel <louise@openrobotics.org>
chapulina
removed
the
needs upstream release
caguero
reviewed
Apr 14, 2022
Collaborator
caguero
left a comment
caguero
left a comment
There was a problem hiding this comment.
Should we add a note into Migration.md?
mjcarroll
approved these changes
Apr 14, 2022
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Contributor
Author
|
Migration note updated in 0fbde9f |
caguero
approved these changes
Apr 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Requires Option to install a header, but don't include it in master header gz-cmake#234Summary
Prevent the deprecated header from being included by anyone who includes
msgs.hh.This is technically not a soft tick, because someone relying on the suppression macros from
msgs.hhwould be broken, but I think there's probably zero people doing this.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸