Download dependencies by JShep1 · Pull Request #123 · gazebosim/gz-fuel-tools

JShep1 · 2020-10-02T19:32:33Z

Downloads all models in the <dependency> tag within a given model's metadata.pbtxt file and within the <depend> tag in a model.config. Cyclic dependencies are also allowed. A step towards getting #111 resolved.

Depends on https://github.com/ignitionrobotics/ign-msgs/pull/91/files

Signed-off-by: John Shepherd john@openrobotics.org

Signed-off-by: John Shepherd <john@openrobotics.org>

codecov · 2020-10-02T19:36:33Z

Codecov Report

Merging #123 (d97e420) into ign-fuel-tools4 (ad1967a) will increase coverage by 0.13%.
The diff coverage is 95.00%.

@@                 Coverage Diff                 @@
##           ign-fuel-tools4     #123      +/-   ##
===================================================
+ Coverage            77.12%   77.26%   +0.13%     
===================================================
  Files                   19       19              
  Lines                 2535     2555      +20     
===================================================
+ Hits                  1955     1974      +19     
- Misses                 580      581       +1

Impacted Files	Coverage Δ
src/FuelClient.cc	`68.82% <95.00%> (+0.87%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad1967a...d97e420. Read the comment docs.

Signed-off-by: John Shepherd <john@openrobotics.org>

JShep1 · 2020-10-06T23:34:46Z

Should we also add support for model.config depend tags?

chapulina · 2020-10-06T23:41:30Z

Should we also add support for model.config depend tags?

I'll leave that up to @nkoenig .

Could you add some tests? Probably somewhere here: https://github.com/ignitionrobotics/ign-fuel-tools/blob/d892487b4e99b1bb8197ccbcb4533731831de4fa/src/FuelClient_TEST.cc#L397

JShep1 · 2020-10-07T00:00:53Z

Could you add some tests? Probably somewhere here:

Sure, I'm currently working on base case example model that I'll add to the tests once I can upload it.

Signed-off-by: John Shepherd <john@openrobotics.org>

JShep1 · 2020-10-07T05:51:52Z

I added support for downloading dependencies from model.config here: #124 . We can cancel it if it's not the direction we want to go, I mainly did it to test as I can't currently upload .pbtxt files onto fuel for testing.

…_dep_download Add support for model config dependencies

JShep1 · 2020-10-12T23:34:42Z

Converting to draft until I can get some tests in

Signed-off-by: John Shepherd <john@openrobotics.org>

src/FuelClient.cc

Signed-off-by: John Shepherd <john@openrobotics.org>

nkoenig · 2020-11-12T16:59:06Z

Support for model.config is fine. In the long run we should deprecate and remove model.config. We don't have a plan for that yet though.

nkoenig · 2020-11-12T17:52:39Z

I'm getting the same test failure locally as CI.

chapulina · 2020-11-16T17:58:43Z

@osrf-jenkins run tests now that ign-msgs 5.4.0 is out

JShep1 · 2020-11-23T02:48:28Z

@nkoenig Could I get a re-review? Not sure why Github isn't letting me re-request.

chapulina

Nice!

* Use lowercase resource and owner names when storing assets on disk (#130) * Use lowercase resource and owner names when storing assets on disk Signed-off-by: Nate Koenig <nate@openrobotics.org> * Remove added diff text from merge Signed-off-by: John Shepherd <john@openrobotics.org> * change model version in test back Signed-off-by: John Shepherd <john@openrobotics.org> * Fix test Signed-off-by: Nate Koenig <nate@openrobotics.org> * Fix windows Signed-off-by: Nate Koenig <nate@openrobotics.org> * Fix more windows tests Signed-off-by: Nate Koenig <nate@openrobotics.org> * Testing another windows fix Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: John Shepherd <john@openrobotics.org> * Prepare for 3.5.0 release (#135) * Prepare for 3.5.0 release Signed-off-by: Nate Koenig <nate@openrobotics.org> * Update Changelog.md Co-authored-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Louise Poubel <louise@openrobotics.org> * Download model dependencies (#123) Signed-off-by: John Shepherd <john@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org> * Prepare for 4.3.0 release (#139) Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org> * Set keep alive on (#141) Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: John Shepherd <john@openrobotics.org> Co-authored-by: Louise Poubel <louise@openrobotics.org>

* Use lowercase resource and owner names when storing assets on disk (#130) * Use lowercase resource and owner names when storing assets on disk Signed-off-by: Nate Koenig <nate@openrobotics.org> * Remove added diff text from merge Signed-off-by: John Shepherd <john@openrobotics.org> * change model version in test back Signed-off-by: John Shepherd <john@openrobotics.org> * Fix test Signed-off-by: Nate Koenig <nate@openrobotics.org> * Fix windows Signed-off-by: Nate Koenig <nate@openrobotics.org> * Fix more windows tests Signed-off-by: Nate Koenig <nate@openrobotics.org> * Testing another windows fix Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: John Shepherd <john@openrobotics.org> * Prepare for 3.5.0 release (#135) * Prepare for 3.5.0 release Signed-off-by: Nate Koenig <nate@openrobotics.org> * Update Changelog.md Co-authored-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Louise Poubel <louise@openrobotics.org> * Download model dependencies (#123) Signed-off-by: John Shepherd <john@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org> * Prepare for 4.3.0 release (#139) Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org> * Set keep alive on (#141) Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org> * Support editing/patching model files (#140) * Support editing/patching model files Signed-off-by: Nate Koenig <nate@openrobotics.org> * Added documentation Signed-off-by: Nate Koenig <nate@openrobotics.org> * Set keep alive on Signed-off-by: Nate Koenig <nate@openrobotics.org> * Documentation and tests Signed-off-by: Nate Koenig <nate@openrobotics.org> * One more test and exit catch missing -u Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org> * Prepare for 5.1.0 release (#145) Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org> * Fix light map URI (#146) Signed-off-by: Ian Chen <ichen@osrfoundation.org> * Bump to 5.1.1 (#147) Signed-off-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Nate Koenig <nkoenig@users.noreply.github.com> Co-authored-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: John Shepherd <john@openrobotics.org> Co-authored-by: Ian Chen <ichen@osrfoundation.org>

Download dependencies

3205387

Signed-off-by: John Shepherd <john@openrobotics.org>

github-actions bot added the 🏰 citadel Ignition Citadel label Oct 2, 2020

John Shepherd added 3 commits October 2, 2020 12:36

Clean up

8c411d3

Signed-off-by: John Shepherd <john@openrobotics.org>

Correct typo

7420da7

Signed-off-by: John Shepherd <john@openrobotics.org>

Prevent cyclic dependencies

86cfba8

Signed-off-by: John Shepherd <john@openrobotics.org>

JShep1 marked this pull request as ready for review October 6, 2020 19:47

JShep1 requested a review from nkoenig as a code owner October 6, 2020 19:47

JShep1 linked an issue Oct 6, 2020 that may be closed by this pull request

Support model dependencies #111

Closed

JShep1 removed a link to an issue Oct 6, 2020

Support model dependencies #111

Closed

JShep1 mentioned this pull request Oct 6, 2020

Support model dependencies #111

Closed

Add support for model config dependencies

90e1069

Signed-off-by: John Shepherd <john@openrobotics.org>

Merge pull request #124 from ignitionrobotics/jshep1/add_model_config…

f7fd8eb

…_dep_download Add support for model config dependencies

JShep1 marked this pull request as draft October 12, 2020 23:34

JShep1 added the needs upstream release Blocked by a release of an upstream library label Oct 13, 2020

Add tests

b0a360d

Signed-off-by: John Shepherd <john@openrobotics.org>

JShep1 marked this pull request as ready for review October 13, 2020 19:08

Merge branch 'ign-fuel-tools4' into jshep1/download_dependencies

da064bb

nkoenig requested changes Nov 5, 2020

View reviewed changes

src/FuelClient.cc Outdated Show resolved Hide resolved

src/FuelClient.cc Outdated Show resolved Hide resolved

src/FuelClient.cc Outdated Show resolved Hide resolved

John Shepherd and others added 3 commits November 9, 2020 15:56

Condense logic

d8c0dca

Signed-off-by: John Shepherd <john@openrobotics.org>

fix typo

8be4d03

Signed-off-by: John Shepherd <john@openrobotics.org>

Merge branch 'ign-fuel-tools4' into jshep1/download_dependencies

d97e420

chapulina assigned JShep1 Nov 16, 2020

JShep1 requested a review from nkoenig November 16, 2020 19:32

chapulina removed the needs upstream release Blocked by a release of an upstream library label Nov 16, 2020

nkoenig approved these changes Nov 30, 2020

View reviewed changes

chapulina approved these changes Nov 30, 2020

View reviewed changes

chapulina merged commit 59547e9 into ign-fuel-tools4 Nov 30, 2020

chapulina deleted the jshep1/download_dependencies branch November 30, 2020 20:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Download dependencies#123

Download dependencies#123
chapulina merged 11 commits intoign-fuel-tools4from
jshep1/download_dependencies

JShep1 commented Oct 2, 2020 •

edited

Loading

Uh oh!

codecov bot commented Oct 2, 2020 •

edited

Loading

Uh oh!

JShep1 commented Oct 6, 2020

Uh oh!

chapulina commented Oct 6, 2020

Uh oh!

JShep1 commented Oct 7, 2020

Uh oh!

JShep1 commented Oct 7, 2020

Uh oh!

JShep1 commented Oct 12, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nkoenig commented Nov 12, 2020

Uh oh!

nkoenig commented Nov 12, 2020

Uh oh!

chapulina commented Nov 16, 2020

Uh oh!

JShep1 commented Nov 23, 2020

Uh oh!

chapulina left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

JShep1 commented Oct 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Oct 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

JShep1 commented Oct 6, 2020

Uh oh!

chapulina commented Oct 6, 2020

Uh oh!

JShep1 commented Oct 7, 2020

Uh oh!

JShep1 commented Oct 7, 2020

Uh oh!

JShep1 commented Oct 12, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nkoenig commented Nov 12, 2020

Uh oh!

nkoenig commented Nov 12, 2020

Uh oh!

chapulina commented Nov 16, 2020

Uh oh!

JShep1 commented Nov 23, 2020

Uh oh!

chapulina left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

JShep1 commented Oct 2, 2020 •

edited

Loading

codecov bot commented Oct 2, 2020 •

edited

Loading