Merged
Conversation
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## ign-fuel-tools4 #141 +/- ##
===================================================
+ Coverage 77.27% 77.30% +0.02%
===================================================
Files 19 19
Lines 2557 2560 +3
===================================================
+ Hits 1976 1979 +3
Misses 581 581
Continue to review full report at Codecov.
|
chapulina
approved these changes
Dec 4, 2020
nkoenig
added a commit
that referenced
this pull request
Dec 9, 2020
* Use lowercase resource and owner names when storing assets on disk (#130) * Use lowercase resource and owner names when storing assets on disk Signed-off-by: Nate Koenig <nate@openrobotics.org> * Remove added diff text from merge Signed-off-by: John Shepherd <john@openrobotics.org> * change model version in test back Signed-off-by: John Shepherd <john@openrobotics.org> * Fix test Signed-off-by: Nate Koenig <nate@openrobotics.org> * Fix windows Signed-off-by: Nate Koenig <nate@openrobotics.org> * Fix more windows tests Signed-off-by: Nate Koenig <nate@openrobotics.org> * Testing another windows fix Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: John Shepherd <john@openrobotics.org> * Prepare for 3.5.0 release (#135) * Prepare for 3.5.0 release Signed-off-by: Nate Koenig <nate@openrobotics.org> * Update Changelog.md Co-authored-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Louise Poubel <louise@openrobotics.org> * Download model dependencies (#123) Signed-off-by: John Shepherd <john@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org> * Prepare for 4.3.0 release (#139) Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org> * Set keep alive on (#141) Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: John Shepherd <john@openrobotics.org> Co-authored-by: Louise Poubel <louise@openrobotics.org>
nkoenig
added a commit
that referenced
this pull request
Dec 23, 2020
* Use lowercase resource and owner names when storing assets on disk (#130) * Use lowercase resource and owner names when storing assets on disk Signed-off-by: Nate Koenig <nate@openrobotics.org> * Remove added diff text from merge Signed-off-by: John Shepherd <john@openrobotics.org> * change model version in test back Signed-off-by: John Shepherd <john@openrobotics.org> * Fix test Signed-off-by: Nate Koenig <nate@openrobotics.org> * Fix windows Signed-off-by: Nate Koenig <nate@openrobotics.org> * Fix more windows tests Signed-off-by: Nate Koenig <nate@openrobotics.org> * Testing another windows fix Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: John Shepherd <john@openrobotics.org> * Prepare for 3.5.0 release (#135) * Prepare for 3.5.0 release Signed-off-by: Nate Koenig <nate@openrobotics.org> * Update Changelog.md Co-authored-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Louise Poubel <louise@openrobotics.org> * Download model dependencies (#123) Signed-off-by: John Shepherd <john@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org> * Prepare for 4.3.0 release (#139) Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org> * Set keep alive on (#141) Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org> * Support editing/patching model files (#140) * Support editing/patching model files Signed-off-by: Nate Koenig <nate@openrobotics.org> * Added documentation Signed-off-by: Nate Koenig <nate@openrobotics.org> * Set keep alive on Signed-off-by: Nate Koenig <nate@openrobotics.org> * Documentation and tests Signed-off-by: Nate Koenig <nate@openrobotics.org> * One more test and exit catch missing -u Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org> * Prepare for 5.1.0 release (#145) Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org> * Fix light map URI (#146) Signed-off-by: Ian Chen <ichen@osrfoundation.org> * Bump to 5.1.1 (#147) Signed-off-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Nate Koenig <nkoenig@users.noreply.github.com> Co-authored-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: John Shepherd <john@openrobotics.org> Co-authored-by: Ian Chen <ichen@osrfoundation.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds keepalive options to curl. The command line version of curl has this enabled by default, and I've found that these parameters help downloading large models and collections.
Reference: https://curl.se/libcurl/c/CURLOPT_TCP_KEEPALIVE.html
Reference: https://ec.haxx.se/usingcurl/usingcurl-timeouts#:~:text=By%20using%20keep%2Dalive%2C%20curl,default%20value%20is%2060%20seconds.
Signed-off-by: Nate Koenig nate@openrobotics.org