Support editing/patching model files#140
Conversation
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## ign-fuel-tools4 #140 +/- ##
===================================================
+ Coverage 77.30% 78.55% +1.24%
===================================================
Files 19 19
Lines 2560 2583 +23
===================================================
+ Hits 1979 2029 +50
+ Misses 581 554 -27
Continue to review full report at Codecov.
|
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
chapulina
left a comment
There was a problem hiding this comment.
I understand that testing a successful edit would be complicated, but maybe we could at least add some tests for some of the failure modes, to cover part of the code.
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Some tests added in e3ae7d8 |
chapulina
left a comment
There was a problem hiding this comment.
Works for me 👍
One weird thing I ran into was that I forgot to pass -u to the edit command, and I got this error message:
Invalid URL: only models can be edited right now.
I think we could catch the missing URL earlier.
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Added early catch in aa8250c. |
* Use lowercase resource and owner names when storing assets on disk (#130) * Use lowercase resource and owner names when storing assets on disk Signed-off-by: Nate Koenig <nate@openrobotics.org> * Remove added diff text from merge Signed-off-by: John Shepherd <john@openrobotics.org> * change model version in test back Signed-off-by: John Shepherd <john@openrobotics.org> * Fix test Signed-off-by: Nate Koenig <nate@openrobotics.org> * Fix windows Signed-off-by: Nate Koenig <nate@openrobotics.org> * Fix more windows tests Signed-off-by: Nate Koenig <nate@openrobotics.org> * Testing another windows fix Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: John Shepherd <john@openrobotics.org> * Prepare for 3.5.0 release (#135) * Prepare for 3.5.0 release Signed-off-by: Nate Koenig <nate@openrobotics.org> * Update Changelog.md Co-authored-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Louise Poubel <louise@openrobotics.org> * Download model dependencies (#123) Signed-off-by: John Shepherd <john@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org> * Prepare for 4.3.0 release (#139) Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org> * Set keep alive on (#141) Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org> * Support editing/patching model files (#140) * Support editing/patching model files Signed-off-by: Nate Koenig <nate@openrobotics.org> * Added documentation Signed-off-by: Nate Koenig <nate@openrobotics.org> * Set keep alive on Signed-off-by: Nate Koenig <nate@openrobotics.org> * Documentation and tests Signed-off-by: Nate Koenig <nate@openrobotics.org> * One more test and exit catch missing -u Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org> * Prepare for 5.1.0 release (#145) Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org> * Fix light map URI (#146) Signed-off-by: Ian Chen <ichen@osrfoundation.org> * Bump to 5.1.1 (#147) Signed-off-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Nate Koenig <nkoenig@users.noreply.github.com> Co-authored-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: John Shepherd <john@openrobotics.org> Co-authored-by: Ian Chen <ichen@osrfoundation.org>
This allows an
editcommand to change a model's files, metadata, tags, etc.Example usage:
Signed-off-by: Nate Koenig nate@openrobotics.org