Expose camera intrinsic matrix API#700
Merged
adityapande-1995 merged 7 commits intomainfrom Sep 7, 2022
Merged
Conversation
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
8 tasks
Codecov Report
@@ Coverage Diff @@
## main #700 +/- ##
==========================================
+ Coverage 74.16% 74.18% +0.01%
==========================================
Files 159 159
Lines 14370 14381 +11
==========================================
+ Hits 10657 10668 +11
Misses 3713 3713
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Contributor
adityapande-1995
left a comment
adityapande-1995
left a comment
There was a problem hiding this comment.
Could you add some tests for this one ?
Contributor
Author
yes working on them:) |
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
jacobperron
reviewed
Aug 11, 2022
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
Contributor
|
Looks good to me overall, with the math simplified and the calculation documented ! |
Signed-off-by: Aditya <aditya050995@gmail.com>
Signed-off-by: Aditya <aditya050995@gmail.com>
8 tasks
jacobperron
approved these changes
Sep 6, 2022
9 tasks
Contributor
|
This is to be reverted in favour of #755 |
adityapande-1995
added a commit
that referenced
this pull request
Nov 2, 2022
This reverts commit 581aaab.
adityapande-1995
added a commit
that referenced
this pull request
Nov 2, 2022
This reverts commit 581aaab. Signed-off-by: Aditya <aditya050995@gmail.com>
adityapande-1995
added a commit
that referenced
this pull request
Nov 3, 2022
adityapande-1995
added a commit
that referenced
this pull request
Nov 8, 2022
ahcorde
pushed a commit
that referenced
this pull request
Sep 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: deepanshu deepanshubansal01@gmail.com
🦟 Bug fix
Fixes gazebosim/gz-sim#705
Summary
This PR solves the camera intrinsics not being reflected properly in
/camera_infotopic when the<intrinsics>tag is not provided. The PR exposes theCameraIntrinsicMatrix()which can be used by downstream packagesgz-sensorsto update the DOM object and also the/camera_infotopic with correct intrinsics.Depends on
gazebosim/gz-sensors#256
Checklist
codecheckpassed (See contributing)🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸