Skip to content

Update Camera Intrinsics in camera_info topic#265

Closed
adityapande-1995 wants to merge 1 commit intomainfrom
aditya/pr_256_copy
Closed

Update Camera Intrinsics in camera_info topic#265
adityapande-1995 wants to merge 1 commit intomainfrom
aditya/pr_256_copy

Conversation

@adityapande-1995
Copy link
Contributor

🦟 Bug fix

This is a copy of #256 by @deepanshubansal01 with the merge conflicts and signoff errors resolved. The original PR was approved.

Fixes gazebosim/gz-sim#705

Summary

This PR solves the camera intrinsics not being reflected properly in /camera_info topic when the <intrinsics> tag is not provided. The PR uses the CameraIntrinsicMatrix() from gz-rendering package to get the camera intrinsics and update the sdf DOM object and /camera_info topic.

Depends on

gazebosim/gz-rendering#700

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Aditya <aditya050995@gmail.com>
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Sep 2, 2022
@adityapande-1995 adityapande-1995 changed the base branch from ign-sensors6 to main September 2, 2022 19:54
@ahcorde ahcorde added the needs upstream release Blocked by a release of an upstream library label Sep 5, 2022
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adityapande-1995
Copy link
Contributor Author

LGTM with green CI, but CI is failing https://github.com/gazebosim/gz-sensors/runs/8163139917?check_suite_focus=true

It was due to this pending PR : gazebosim/gz-rendering#700

@adityapande-1995
Copy link
Contributor Author

@osrf-jenkins retest this please

@azeey azeey removed the 🏯 fortress Ignition Fortress label Oct 3, 2022
@azeey
Copy link

azeey commented Oct 3, 2022

This needs dependency versions bumped for gz-rendering.

@adityapande-1995
Copy link
Contributor Author

Closing in favour of #281

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs upstream release Blocked by a release of an upstream library

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

CameraInfo's projection matrix not updating when resolution changes

4 participants