Update Camera Intrinsics in camera_info topic#265
Closed
adityapande-1995 wants to merge 1 commit intomainfrom
Closed
Update Camera Intrinsics in camera_info topic#265adityapande-1995 wants to merge 1 commit intomainfrom
adityapande-1995 wants to merge 1 commit intomainfrom
Conversation
8 tasks
ahcorde
requested changes
Sep 5, 2022
Contributor
ahcorde
left a comment
There was a problem hiding this comment.
LGTM with green CI, but CI is failing https://github.com/gazebosim/gz-sensors/runs/8163139917?check_suite_focus=true
Contributor
Author
It was due to this pending PR : gazebosim/gz-rendering#700 |
Contributor
Author
|
@osrf-jenkins retest this please |
|
This needs dependency versions bumped for gz-rendering. |
9 tasks
Contributor
Author
|
Closing in favour of #281 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
This is a copy of #256 by @deepanshubansal01 with the merge conflicts and signoff errors resolved. The original PR was approved.
Fixes gazebosim/gz-sim#705
Summary
This PR solves the camera intrinsics not being reflected properly in
/camera_infotopic when the<intrinsics>tag is not provided. The PR uses theCameraIntrinsicMatrix()fromgz-renderingpackage to get the camera intrinsics and update the sdf DOM object and/camera_infotopic.Depends on
gazebosim/gz-rendering#700
Checklist
codecheckpassed (See contributing)🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸