Update Camera Intrinsics in camera_info topic#256
Closed
deepanshubansal01 wants to merge 9 commits intomainfrom
Closed
Update Camera Intrinsics in camera_info topic#256deepanshubansal01 wants to merge 9 commits intomainfrom
deepanshubansal01 wants to merge 9 commits intomainfrom
Conversation
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
8 tasks
deepanshubansal01
changed the title
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
jacobperron
reviewed
Aug 11, 2022
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
jacobperron
reviewed
Aug 15, 2022
Signed-off-by: deepanshu <deepanshubansal01@gmail.com>
jacobperron
approved these changes
Aug 18, 2022
jacobperron
left a comment
jacobperron
left a comment
There was a problem hiding this comment.
Changes LGTM, I'll leave it up to @iche033 for final review.
Contributor
adityapande-1995
left a comment
adityapande-1995
left a comment
There was a problem hiding this comment.
In the analogous PR in gazebo classic, we have 3 instances of the camera : One with no intrinsics tag (which uses gazebo defaults), one with intrinsics with the same values as gazebo defaults, and one which has some custom values. It would be nice to keep the tests consistent here as well, though not a necessity.
adityapande-1995
added a commit
that referenced
this pull request
Sep 2, 2022
8 tasks
Contributor
|
Closing this in favour of #265 with the merge conflicts and signoff errors resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes gazebosim/gz-sim#705
Summary
This PR solves the camera intrinsics not being reflected properly in
/camera_infotopic when the<intrinsics>tag is not provided. The PR uses theCameraIntrinsicMatrix()fromgz-renderingpackage to get the camera intrinsics and update the sdf DOM object and/camera_infotopic.Depends on
gazebosim/gz-rendering#700
Checklist
codecheckpassed (See contributing)🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸