Merged
Conversation
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Closed
Contributor
|
Great you started working on this. So how does this go together with the SDF spec? In #9, you mentioned custom namespaces, but that's not the case used in the example. What if I needed a some XML parameters completely unknown to the SDF spec? Also, the wording of http://sdformat.org/spec?ver=1.7&elem=sensor#sensor_type could be changed to better reflect the fact that plugins can add more supported sensor types. |
ahcorde
requested changes
Feb 17, 2021
Contributor
Author
|
Removing beta label, we won't have time to wrap this up before code freeze. Let's retarget at Ignition-F. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Closes #9
Builds on top of #90
Summary
Add support for custom sensors that aren't installed together with
ign-sensors, so that external users can implement their own sensors. This adds:IGN_SENSORS_PATHthat users can set to find sensors.It also makes the deprecated
Updatefunction non-pure-virtual, so downstream developers aren't forced to implement a deprecated function.I decided to work on this to validate that the work being done on #90 was flexible enough to support external sensors.
Test it
Follow the instructions on each example's READMEs.
Checklist
tutorialsIGN_SENSORS_PATHsomewherecodecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge