Add BoundingBox Sensor#136
Conversation
Signed-off-by: AmrElsersy <amrelsersay@gmail.com>
Signed-off-by: AmrElsersy <amrelsersay@gmail.com>
Signed-off-by: AmrElsersy <amrelsersay@gmail.com>
Signed-off-by: AmrElsersy <amrelsersay@gmail.com>
Signed-off-by: AmrElsersy <amrelsersay@gmail.com>
Signed-off-by: AmrElsersy <amrelsersay@gmail.com>
Signed-off-by: AmrElsersy <amrelsersay@gmail.com>
src/BoundingBoxCameraSensor.cc
Outdated
| auto oriented3DBox = new msgs::Oriented3DBox(); | ||
| auto center = new msgs::Vector3d(); | ||
| auto size = new msgs::Vector3d(); | ||
| auto rotation = new msgs::Quaternion(); |
There was a problem hiding this comment.
Is there a chance for memory leaks here? It looks like these variables are added to the message, but when/how are they de-allocated?
There was a problem hiding this comment.
I don't know yet a way about how to deallocate it
is it deleted when we call the MSG_NAME.clear() function ?
I mean the whole msg, the AnnotatedAxisAligned2DBox_V
src/BoundingBoxCameraSensor.cc
Outdated
| auto axisAlignedBox = new msgs::AxisAligned2DBox(); | ||
| auto min_corner = new msgs::Vector2d(); | ||
| auto max_corner = new msgs::Vector2d(); |
There was a problem hiding this comment.
same question as my previous comment about memory leaks
Signed-off-by: AmrElsersy <amrelsersay@gmail.com>
…into BoundingBox Signed-off-by: AmrElsersy <amrelsersay@gmail.com>
Signed-off-by: AmrElsersy <amrelsersay@gmail.com>
Signed-off-by: AmrElsersy <amrelsersay@gmail.com>
Signed-off-by: AmrElsersy <amrelsersay@gmail.com>
Signed-off-by: AmrElsersy <amrelsersay@gmail.com>
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/gsoc-2021-machine-learning-extension-to-ignition-gazebo/1070/1 |
Signed-off-by: Ashton Larkin <ashton@openrobotics.org>
Signed-off-by: AmrElsersy <amrelsersay@gmail.com>
Signed-off-by: AmrElsersy <amrelsersay@gmail.com>
Signed-off-by: AmrElsersy <amrelsersay@gmail.com>
Signed-off-by: AmrElsersy <amrelsersay@gmail.com>
|
gazebosim/gz-rendering#334 won't make it in time for code freeze, so I'll remove this PR from |
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## ign-sensors6 #136 +/- ##
================================================
- Coverage 80.00% 72.16% -7.84%
================================================
Files 1 34 +33
Lines 15 3470 +3455
================================================
+ Hits 12 2504 +2492
- Misses 3 966 +963
Continue to review full report at Codecov.
|
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: AmrElsersy amrelsersay@gmail.com
🎉 New feature
related to #135
Summary
BoundingBox Camera Sensor that allow users to use it easily in SDF, and It publishes the sensor data (bounding boxes) to ign-transport.
It published both BoundingBoxes Msg & Image (with drawn boxes on it for visualization)
Depends on
Gazebo #853
SDF #592
Rendering #334
Msgs #165
Demo
Test it
Will add a tutorial later.
Format
It requires visuals annotating in the sdf via Gazeb #853
Checklist
codecheckpassed (See contributing)Notes
Full Bounding Boxes mode dosn't work yet here, But it works in rendering::BoundingBoxCamera, I think because the view matrix of the ogre camera dosn't change with the change of the node's pose ... still searching :D