Skip to content

Remove deprecations: tock#141

Merged
ahcorde merged 1 commit intomainfrom
chapulina/6/deprecations
Jun 25, 2021
Merged

Remove deprecations: tock#141
ahcorde merged 1 commit intomainfrom
chapulina/6/deprecations

Conversation

@chapulina
Copy link
Contributor

Summary

Perform the tock of the tick-tock.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina requested a review from iche033 as a code owner June 25, 2021 00:53
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Jun 25, 2021
@codecov
Copy link

codecov bot commented Jun 25, 2021

Codecov Report

Merging #141 (12e74c6) into main (b7097d1) will increase coverage by 1.13%.
The diff coverage is n/a.

❗ Current head 12e74c6 differs from pull request most recent head b6074d0. Consider uploading reports for the commit b6074d0 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #141      +/-   ##
==========================================
+ Coverage   76.10%   77.23%   +1.13%     
==========================================
  Files          23       23              
  Lines        2390     2355      -35     
==========================================
  Hits         1819     1819              
+ Misses        571      536      -35     
Impacted Files Coverage Δ
include/ignition/sensors/Manager.hh 75.00% <ø> (ø)
src/AirPressureSensor.cc 85.71% <ø> (+2.38%) ⬆️
src/AltimeterSensor.cc 88.09% <ø> (+2.04%) ⬆️
src/CameraSensor.cc 74.72% <ø> (+1.36%) ⬆️
src/DepthCameraSensor.cc 73.94% <ø> (+0.61%) ⬆️
src/GpuLidarSensor.cc 88.23% <ø> (+1.13%) ⬆️
src/ImuSensor.cc 90.19% <ø> (+1.73%) ⬆️
src/Lidar.cc 72.34% <ø> (+1.50%) ⬆️
src/LogicalCameraSensor.cc 89.70% <ø> (+2.56%) ⬆️
src/MagnetometerSensor.cc 88.23% <ø> (+2.02%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7097d1...b6074d0. Read the comment docs.

@ahcorde ahcorde merged commit 53c87ea into main Jun 25, 2021
@ahcorde ahcorde deleted the chapulina/6/deprecations branch June 25, 2021 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏯 fortress Ignition Fortress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants