Add API for enabling / disabling IMU orientation#142
Merged
chapulina merged 3 commits intoign-sensors4from Jul 10, 2021
Merged
Conversation
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Codecov Report
@@ Coverage Diff @@
## ign-sensors4 #142 +/- ##
================================================
+ Coverage 76.10% 76.16% +0.05%
================================================
Files 23 23
Lines 2390 2396 +6
================================================
+ Hits 1819 1825 +6
Misses 571 571
Continue to review full report at Codecov.
|
This was referenced Jul 2, 2021
chapulina
approved these changes
Jul 2, 2021
Contributor
chapulina
left a comment
chapulina
left a comment
There was a problem hiding this comment.
LGTM, just a nit about style.
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
ahcorde
approved these changes
Jul 2, 2021
Contributor
ahcorde
left a comment
ahcorde
left a comment
There was a problem hiding this comment.
A minor style issue, but otherwise LGTM
| // orientation should still be the previous value because it is not being | ||
| // updated. | ||
| EXPECT_EQ(newOrientValue, sensor->Orientation()); | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ian Chen ichen@osrfoundation.org
🎉 New feature
Not all IMUs produce orientation estimates. This PR adds a new API to the IMU sensor class to allow users to disable computing and publishing orientation values.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge