Skip to content

[garden] Use anti-aliasing value from <anti_aliasing> SDF element #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iche033 merged 8 commits into from
Jun 14, 2022
Merged

[garden] Use anti-aliasing value from <anti_aliasing> SDF element #210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
711af9a
Use anti-aliasing value from SDF
WilliamLewww Mar 29, 2022
747a7e6
Merge branch 'main' into wlew/anti_aliasing
WilliamLewww Apr 6, 2022
2d517e5
Merge branch 'main' into wlew/anti_aliasing
WilliamLewww Apr 21, 2022
67c35ac
Merge branch 'main' into wlew/anti_aliasing
WilliamLewww May 20, 2022
1598aa9
Merge branch 'main' into wlew/anti_aliasing
WilliamLewww Jun 1, 2022
9f213ea
Merge branch 'main' into wlew/anti_aliasing
WilliamLewww Jun 1, 2022
abd7948
Merge branch 'main' into wlew/anti_aliasing
scpeters Jun 8, 2022
6aa4cb9
update migration guide
scpeters Jun 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Migration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ release will remove the deprecated code.
1. Header files under `ignition/...` are deprecated and will be removed in future versions.
Use `gz/...` instead.

1. **CameraSensor**: the default anti-aliasing value has changed from `2` to `4`.

## Gazebo Sensors 6.0.1 to 6.1.0

### Modifications
Expand Down
2 changes: 1 addition & 1 deletion src/CameraSensor.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ bool CameraSensor::CreateCamera()
}

// \todo(nkoeng) these parameters via sdf
this->dataPtr->camera->SetAntiAliasing(2);
this->dataPtr->camera->SetAntiAliasing(cameraSdf->AntiAliasingValue());
Copy link
Member

@scpeters scpeters Jun 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the default value in SDFormat is 4, so this will represent a behavior change

Copy link
Contributor

@iche033 iche033 Jun 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm it may be worth putting a note in the migration guide about this change, otherwise changes look good to me.

Copy link
Member

@scpeters scpeters Jun 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6aa4cb9


math::Angle angle = cameraSdf->HorizontalFov();
if (angle < 0.01 || angle > IGN_PI*2)
Expand Down