Disable thermal camera test on MacOS#243
Merged
Blast545 merged 1 commit intoign-sensors6from Jul 6, 2022
Merged
Conversation
Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
Codecov Report
@@ Coverage Diff @@
## ign-sensors6 #243 +/- ##
=============================================
Coverage 72.16% 72.16%
=============================================
Files 34 34
Lines 3470 3470
=============================================
Hits 2504 2504
Misses 966 966 Continue to review full report at Codecov.
|
chapulina
approved these changes
Jul 6, 2022
iche033
approved these changes
Jul 6, 2022
Contributor
Author
|
There seems to be some other errors Jammy github actions CI that will be addressed separately. Thanks for the reviews! Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jorge Perez jjperez@ekumenlabs.com
Summary
Disabling a faling test on MacOS, I think it's closely related to same error described here: gazebosim/gz-rendering#654. I think it's better to track both issues together, I can open a new issue if it's preferred for this test.
Should fix remaining test regression on MacOS + Fortress buildfarm jobs.
Reference, see: https://build.osrfoundation.org/job/ignition_sensors-ci-ign-sensors6-homebrew-amd64/25/
FYI: @Crola1702
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.