Skip to content

Add noise to RGBD camera#35

Merged
nkoenig merged 1 commit intoign-sensors2from
depth_noise
Aug 7, 2020
Merged

Add noise to RGBD camera#35
nkoenig merged 1 commit intoign-sensors2from
depth_noise

Conversation

@iche033
Copy link
Contributor

@iche033 iche033 commented Aug 6, 2020

Depends on gazebosim/gz-rendering#122

Applies noise to an RGBD camera sensor. The actual noise implementation is done in the ign-rendering pull request

Signed-off-by: Ian Chen ichen@osrfoundation.org

Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@codecov
Copy link

codecov bot commented Aug 6, 2020

Codecov Report

Merging #35 into ign-sensors2 will decrease coverage by 0.26%.
The diff coverage is 42.85%.

Impacted file tree graph

@@               Coverage Diff                @@
##           ign-sensors2      #35      +/-   ##
================================================
- Coverage         80.25%   79.99%   -0.27%     
================================================
  Files                21       21              
  Lines              2046     2059      +13     
================================================
+ Hits               1642     1647       +5     
- Misses              404      412       +8     
Impacted Files Coverage Δ
src/RgbdCameraSensor.cc 74.78% <33.33%> (-2.29%) ⬇️
src/Noise.cc 76.92% <100.00%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2b4904...bb82bcc. Read the comment docs.

@nkoenig nkoenig merged commit d84ef53 into ign-sensors2 Aug 7, 2020
@nkoenig nkoenig deleted the depth_noise branch August 7, 2020 13:05
@peci1
Copy link
Contributor

peci1 commented Aug 17, 2020

It's good to have this finally implemented. However, it seems to me that multiplicative Gaussian noise would be much closer to reality than additive in the depth measurements. Of course, the real error model would be even more complicated, but I used multiplicative Gaussian noise for depth and it seemed okay...

@azeey azeey mentioned this pull request Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📜 blueprint Ignition Blueprint

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants