Merged
Conversation
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Codecov Report
@@ Coverage Diff @@
## ign-sensors2 #35 +/- ##
================================================
- Coverage 80.25% 79.99% -0.27%
================================================
Files 21 21
Lines 2046 2059 +13
================================================
+ Hits 1642 1647 +5
- Misses 404 412 +8
Continue to review full report at Codecov.
|
nkoenig
approved these changes
Aug 7, 2020
nkoenig
approved these changes
Aug 7, 2020
Contributor
|
It's good to have this finally implemented. However, it seems to me that multiplicative Gaussian noise would be much closer to reality than additive in the depth measurements. Of course, the real error model would be even more complicated, but I used multiplicative Gaussian noise for depth and it seemed okay... |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on gazebosim/gz-rendering#122
Applies noise to an RGBD camera sensor. The actual noise implementation is done in the ign-rendering pull request
Signed-off-by: Ian Chen ichen@osrfoundation.org