Skip to content

Minor cleanup#352

Merged
iche033 merged 4 commits intogazebosim:gz-sensors7from
shameekganguly:cleanup
Jun 8, 2023
Merged

Minor cleanup#352
iche033 merged 4 commits intogazebosim:gz-sensors7from
shameekganguly:cleanup

Conversation

@shameekganguly
Copy link
Contributor

  • Change remaining ignerr to gzerr
  • Add one missing header
  • Ensure parameter names match in function declaration and definition

Signed-off-by: Shameek Ganguly <shameekarcanesphinx@gmail.com>
Signed-off-by: Shameek Ganguly <shameekarcanesphinx@gmail.com>
Signed-off-by: Shameek Ganguly <shameekarcanesphinx@gmail.com>
@shameekganguly shameekganguly requested a review from iche033 as a code owner June 8, 2023 16:23
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jun 8, 2023
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Merging #352 (378c848) into gz-sensors7 (32576a8) will increase coverage by 0.01%.
The diff coverage is 85.71%.

❗ Current head 378c848 differs from pull request most recent head 6d3822f. Consider uploading reports for the commit 6d3822f to get more accurate results

@@               Coverage Diff               @@
##           gz-sensors7     #352      +/-   ##
===============================================
+ Coverage        69.69%   69.70%   +0.01%     
===============================================
  Files               36       36              
  Lines             3956     3958       +2     
===============================================
+ Hits              2757     2759       +2     
  Misses            1199     1199              
Impacted Files Coverage Δ
src/CameraSensor.cc 75.92% <0.00%> (ø)
src/NavSatSensor.cc 89.90% <ø> (ø)
src/GpuLidarSensor.cc 89.26% <100.00%> (ø)
src/SegmentationCameraSensor.cc 54.26% <100.00%> (ø)
src/Sensor.cc 89.94% <100.00%> (+0.10%) ⬆️

@iche033 iche033 merged commit 28089ab into gazebosim:gz-sensors7 Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🌱 garden Ignition Garden

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants