Skip to content

Bumps in harmonic : ci_matching_branch/bump_harmonic_gz-sensors8#367

Merged
azeey merged 2 commits intomainfrom
ci_matching_branch/bump_harmonic_gz-sensors8
Aug 4, 2023
Merged

Bumps in harmonic : ci_matching_branch/bump_harmonic_gz-sensors8#367
azeey merged 2 commits intomainfrom
ci_matching_branch/bump_harmonic_gz-sensors8

Conversation

@azeey
Copy link

@azeey azeey commented Jul 28, 2023

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey requested a review from iche033 as a code owner July 28, 2023 19:15
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Jul 28, 2023
@iche033
Copy link
Contributor

iche033 commented Aug 2, 2023

needs new sdformat14 nightlies for green CI

@azeey
Copy link
Author

azeey commented Aug 2, 2023

needs new sdformat14 nightlies for green CI

Yup. blocked on gazebo-release/sdformat14-release#1

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #367 (372550b) into main (d649800) will not change coverage.
The diff coverage is n/a.

❗ Current head 372550b differs from pull request most recent head 9506b39. Consider uploading reports for the commit 9506b39 to get more accurate results

@@           Coverage Diff           @@
##             main     #367   +/-   ##
=======================================
  Coverage   72.63%   72.63%           
=======================================
  Files          36       36           
  Lines        4948     4948           
=======================================
  Hits         3594     3594           
  Misses       1354     1354           

@mjcarroll
Copy link
Contributor

@osrf-jenkins retest this please

@iche033
Copy link
Contributor

iche033 commented Aug 4, 2023

ignition_sensors-ci-pr_any-ubuntu_auto-amd64 failed because it's run on a jenkins machine that's on focal. I think we can remove this check since gz_sensors-ci-pr_any-jammy-amd64 should be sufficient?

Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. Jammy builds are working

@azeey
Copy link
Author

azeey commented Aug 4, 2023

Is INTEGRATION_dvl flaky? It's failing on Jammy

@mjcarroll
Copy link
Contributor

Is INTEGRATION_dvl flaky?

I believe so, I've seen it before (I think).

@azeey azeey merged commit 7bfc85a into main Aug 4, 2023
@azeey azeey deleted the ci_matching_branch/bump_harmonic_gz-sensors8 branch August 4, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🎵 harmonic Gazebo Harmonic

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants