Tests need to include message types they are using#375
Merged
Conversation
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Codecov Report
@@ Coverage Diff @@
## main #375 +/- ##
=======================================
Coverage 72.62% 72.62%
=======================================
Files 36 36
Lines 4947 4947
=======================================
Hits 3593 3593
Misses 1354 1354
|
ahcorde
approved these changes
Aug 21, 2023
Contributor
ahcorde
left a comment
ahcorde
left a comment
There was a problem hiding this comment.
one boolean header missing, otherwise LGTM
| @@ -19,7 +19,9 @@ | |||
|
|
|||
| #include <gz/msgs/image.pb.h> | |||
Contributor
Author
There was a problem hiding this comment.
Good catch, I can't really detect the things that are already pulled in transitively.
iche033
approved these changes
Aug 22, 2023
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
ahcorde
approved these changes
Aug 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many sensor tests didn't actually include the headers that they were using. This breaks with the new message generation (we are probably transitively including less).